Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hosting ASP.NET Core Images with Docker or move to /dotnet/dotnet-docker #27194

Open
Rick-Anderson opened this issue Oct 4, 2022 · 8 comments
Labels
Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

@Rick-Anderson
Copy link
Contributor

@mthalman would you be able to help either getting this migrated to https://github.com/dotnet/dotnet-docker or updated for .NET 7? You just need to get the instructions correct in a PR and I'll edit and clean up.


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

@dotnet-bot dotnet-bot added ⌚ Not Triaged Source - Docs.ms Docs Customer feedback via GitHub Issue labels Oct 4, 2022
@mthalman
Copy link
Member

mthalman commented Oct 5, 2022

@Rick-Anderson - There are no changes necessary to update the doc for .NET 7. The doc uses the mcr.microsoft.com/dotnet/core/samples:aspnetapp image name automatically gets updated to the next .NET version when we make the necessary changes to upgrade it in https://github.com/dotnet/dotnet-docker. That was already done in dotnet/dotnet-docker#3989. Everything in the doc is compatible between .NET 6 and 7.

@Rick-Anderson
Copy link
Contributor Author

@mthalman I was just saying .NET 7 because if you were to update it, makes sense to update for .NET 7. It was never updated for .NET 6. The history shows the topic hasn't been updated in several years. Most of the history is from the history polluting global doc meta-data updates. Can you verify it's up to date for .NET 6?

@mthalman
Copy link
Member

mthalman commented Oct 6, 2022

Yes, it's relevant for .NET 6 as well. But that's sort of irrelevant since the images that the documentation says to get are now based on .NET 7. We don't maintain separate sample container images for different versions. We only provide the latest version.

@Rick-Anderson
Copy link
Contributor Author

The doc has only one version and seems badly out of date. We normally use monikers for each version. I can make duplicates of the content with as many versions as you like.

## Prerequisites

The [.NET Core 2.2 SDK](https://dotnet.microsoft.com/download) 

That should be the SDK version of the moniker section.

What versions should we support? 7,6,5.1,3.1 ?
Can create the multi version moniker file for you.

@mthalman
Copy link
Member

mthalman commented Oct 6, 2022

I'm fine with just updating that Prerequisite to vary based on the version moniker. But technically, that prereq as it exists today is correct. As long as you have 2.2 SDK or later, it'll create you a cert that will work with the sample. But to avoid confusion, it probably makes sense to have that version relevant to the version of the doc that's selected. That can be scoped to just the currently supported versions: 3.1, 6.0, 7.0.

@Rick-Anderson
Copy link
Contributor Author

@mthalman I'll make 3.1, 6.0, 7.0. versions. You can update the images for each version.

@mthalman
Copy link
Member

mthalman commented Oct 6, 2022

@mthalman I'll make 3.1, 6.0, 7.0. versions. You can update the images for each version.

We don't have separate sample image tags for each version. We provide one tag that gives you the latest version. So there's no change to be made for those.

@Rick-Anderson
Copy link
Contributor Author

@mthalman I'll make 3.1, 6.0, 7.0. versions. You can update the images for each version.

We don't have separate sample image tags for each version. We provide one tag that gives you the latest version. So there's no change to be made for those.

OK, we'll tell them to use the SDK for the version they are targeting. and provide links to 3.1, 6, & 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
None yet
Development

No branches or pull requests

3 participants