Having to use Task.Delay between sends.

[softwareantics]

Take the following code (light abstracted but the Send functions are the same and just serialize an object to bytes to send to my client)

        foreach (var remotePlayer in remotePlayers)
        {
            if (remotePlayer.PlayerId == player.PlayerId)
            {
                continue;
            }

            await context.Send(remotePlayer.ConnectionId, new CreateRemotePlayerCommand()
            {
                Player = player,
            }).ConfigureAwait(false);

            await Task.Delay(100).ConfigureAwait(false);

            await context.Send(new CreateRemotePlayerCommand()
            {
                Player = remotePlayer,
            }).ConfigureAwait(false);
        }

If I am to remove the Task.Delay line only some of the messages are received when more than two or three clients are connected to the server. This is likely a synchronization issue and I was wondering what approach I should take to resolve this?

[softwareantics]

Should I:

• Just batch all the CreateRemotePlayerCommands and send it as one command (there could be a decent amount of players leading to a larger amount of data to send).
• Or, should II design some sort of mechanism that will replace the Task.Delay and wait for acknowledgement from the client before sending the next CreateRemotePlayerCommand?

[jchristn]

Hi @softwareantics you shouldn't have to use a Task.Delay. How many concurrent connections do you have in order to reproduce this, and what is the approximate number of payload bytes you are sending per message? Is there any chance of producing a minimal example that reproduces this using any of the Test projects in the repo?

[softwareantics]

@jchristn I think that maybe this might be an issue on my client. I am using GML for the client-side and have to handle reading the incoming data. Where can I find the logic in WatsonTcp that handles (from the very beginning) an incoming stream? Best case scenario, I can port the logic that is used to handle incoming "packets" from WatsonTcp over to my client in GML.

[softwareantics]

If this doesn't resolve the issue, I'll attempt to setup a scenario where I can reproduce the results using purely C# and WatsonTcp.

[jchristn]

Hi @softwareantics I'd recommend looking at FRAMING.md for an overview. For the logic, I'd look into the WatsonMessage.cs class, along with the DataReceiver methods in both server and client.