Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The arcade-services internal CI build should not run unit tests #2324

Closed
premun opened this issue Mar 2, 2023 · 8 comments
Closed

The arcade-services internal CI build should not run unit tests #2324

premun opened this issue Mar 2, 2023 · 8 comments

Comments

@premun
Copy link
Member

premun commented Mar 2, 2023

We usually don't run tests in the main build again after they've been run in PR so I think we shouldn't run them in arcade-services-official-ci neither.

  • They add 10+ minutes
  • These tests fail every now and then
  • The reason these fail is because of the CodeCoverage tool loading some settings (this should be fixed too regardless)

Release Note Description

Only run tests during PR builds

@premun premun changed the title The arcade-services internal CI build should not run unit tets The arcade-services internal CI build should not run unit tests Mar 8, 2023
@missymessa
Copy link
Member

Add to ProdCon epic.

@premun
Copy link
Member Author

premun commented May 3, 2023

@dkurepa
Copy link
Member

dkurepa commented May 3, 2023

I added it to the epic, looks like a good change. We should also make sure that github is configured so you have to run builds against the latest main

@premun
Copy link
Member Author

premun commented May 3, 2023

Do we want that though? I am not so much in favour of that and we usually don't do that in other repositories

@dkurepa
Copy link
Member

dkurepa commented May 3, 2023

I think we do. Let's say we had two PR's that both passed the public PR validation over night. Merging one could affect the other in some way, I think we'd want to run validation on the second one again, just to be sure

@premun
Copy link
Member Author

premun commented May 3, 2023

I understand the issue, I just don't think it happens so often that it would justify the hassle and time spent waiting rerunning PR builds

@dkurepa dkurepa transferred this issue from dotnet/arcade Jun 1, 2023
@dkurepa
Copy link
Member

dkurepa commented Jun 7, 2023

PR: #2619

@dkurepa
Copy link
Member

dkurepa commented Jun 8, 2023

The PR has been merged. We will only run tests during PR builds now. This should reduce the noise we're getting in main builds because of flaky tests

@dkurepa dkurepa closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants