From 46fe554f611ecbfb1ce7b50a56d1420d718dd420 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Fri, 3 Jul 2020 18:48:15 +0200 Subject: [PATCH] Fix bug in ActiveIssueDiscoverer with condition member names (#5744) In https://github.com/dotnet/arcade/pull/5376 the logic was copied from the ConditionalFactDiscoverer but this is wrong. For ActiveIssue we want to _skip_ the test if the condition is true, rather than the other way round. --- .../src/Discoverers/ActiveIssueDiscoverer.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Microsoft.DotNet.XUnitExtensions/src/Discoverers/ActiveIssueDiscoverer.cs b/src/Microsoft.DotNet.XUnitExtensions/src/Discoverers/ActiveIssueDiscoverer.cs index 508669ce064..1a3ff863b6f 100644 --- a/src/Microsoft.DotNet.XUnitExtensions/src/Discoverers/ActiveIssueDiscoverer.cs +++ b/src/Microsoft.DotNet.XUnitExtensions/src/Discoverers/ActiveIssueDiscoverer.cs @@ -61,11 +61,11 @@ public IEnumerable> GetTraits(IAttributeInfo traitA if (calleeType != null && conditionMemberNames != null) { - if (!DiscovererHelpers.Evaluate(calleeType, conditionMemberNames)) + if (DiscovererHelpers.Evaluate(calleeType, conditionMemberNames)) { yield return new KeyValuePair(XunitConstants.Category, XunitConstants.Failing); } - } + } else if (DiscovererHelpers.TestPlatformApplies(platforms) && DiscovererHelpers.TestRuntimeApplies(runtimes) && DiscovererHelpers.TestFrameworkApplies(frameworks))