[Blazor WASM] UserOptions not bound when published #41998
Comments
javiercn
added
area-blazor
|
@aguacongas thanks for contacting us. We don't have any reason to believe this is a blazor specific behavior. Does the same code work on a console application? I suspect you need to match the casing in the configuration |
javiercn
added
the
Needs: Author Feedback
|
Hi @aguacongas. We have added the "Needs: Author Feedback" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time. |
|
@javiercn I tried to Pascal case the config but that didn't change the result. Much more weird, if you try to bind builder.Services.AddOidcAuthentication(options =>
{
// here the binding works.
builder.Configuration.Bind(nameof(options.ProviderOptions), options.ProviderOptions);
// doesn't work when published
builder.Configuration.Bind(nameof(options.UserOptions), options.UserOptions);
// options.UserOptions.RoleClaim = "role"; works always.
}).AddAccountClaimsPrincipalFactory<ClaimsPrincipalFactory>();
I updated the repo.
|
ghost
added
Needs: Attention 👋
|
@aguacongas does it fail while you are running on development or after you have published the app |
javiercn
added
the
Needs: Author Feedback
|
Hi @aguacongas. We have added the "Needs: Author Feedback" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time. |
javiercn
removed
the
Needs: Attention 👋
|
Only after published, |
ghost
added
Needs: Attention 👋
|
@aguacongas thanks for the additional details. Then it's just a matter of it being trimmed. |
|
It seems that the type is missing the proper annotation. I think it needs to have something like [DynamicallyAccessedMembers(JsonSerialized)] |
javiercn
removed
the
Needs: Attention 👋
|
As a workaround, assign a dummy value before you bind the value from config so that the trimmer doesn't discard the property. |
|
@javiercn is ok to propose a PR to fix it ? |
|
@aguacongas go for it |
|
I don't think adding /cc @eerhardt |
The We do have plans for a source generator (dotnet/runtime#44493) to fix this, but that hasn't been prioritized in .NET 7. For now, either not using ConfigurationBinder and bind the config manually, or preserving the properties with DynamicDependency or explicitly using the properties in code are the best options. |
|
@eerhardt thanks for the additional information. I think based on that, we'll wait for the runtime to deal with better config trimming as there is nothing we can do at our level other than enabling the warnings for RequiresUnreferencedCode which I don't think is something we plan to do in the near future. |
ghost
locked as resolved and limited conversation to collaborators
Is there an existing issue for this?
Describe the bug
When the
RemoteAuthenticationOptions.UserOptionsis bound to a configuration section,RoleClaimis not well read from the configuration when plublished.builder.Services.AddOidcAuthentication(options =>
{
var providerOptions = options.ProviderOptions;
providerOptions.Authority = "https://www.theidserver.com/";
providerOptions.ClientId = "blazorissueclient";
providerOptions.ResponseType = "code";
providerOptions.DefaultScopes.Add("blazorissueapi");
// doesn't work when published
builder.Configuration.Bind(nameof(options.UserOptions), options.UserOptions);
// options.UserOptions.RoleClaim = "role"; works always.
}).AddAccountClaimsPrincipalFactory();
Expected Behavior
RoleClaimshould be read from the configuration and work as usingdotnet runor when launched with VS.Steps To Reproduce
Using this repo.
❯ dotnet run Building... info: Duende.IdentityServer.Startup[0] Starting Duende IdentityServer version 5.2.0+1c3f1fadb0fa7a4bea3f4a6f7028cbfcff3b9918 (.NET 7.0.0-preview.4.22229.4) warn: Duende.IdentityServer[0] You do not have a valid license key for Duende IdentityServer. This is allowed for development and testing scenarios. If you are running in production you are required to have a licensed version. Please start a conversation with us: https://duendesoftware.com/contact info: Duende.IdentityServer.Startup[0] Using explicitly configured authentication scheme Identity.Application for IdentityServer info: Microsoft.Hosting.Lifetime[14] Now listening on: https://localhost:5001 info: Microsoft.Hosting.Lifetime[14] Now listening on: http://localhost:5000 info: Microsoft.Hosting.Lifetime[0] Application started. Press Ctrl+C to shut down. info: Microsoft.Hosting.Lifetime[0] Hosting environment: Development info: Microsoft.Hosting.Lifetime[0] Content root path: C:\Projects\Tests\BlazorAuthIssue\ServerThe page display the forecast. Everthing is OK.
The page display :
Exceptions (if any)
No response
.NET Version
7.0.100-preview.4.22252.9
Anything else?
The text was updated successfully, but these errors were encountered: