Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-counter console output corruption on resize #2934

Closed
Simonl9l opened this issue Mar 13, 2022 · 5 comments
Closed

dotnet-counter console output corruption on resize #2934

Simonl9l opened this issue Mar 13, 2022 · 5 comments
Assignees
Labels
bug Something isn't working dotnet-counters
Milestone

Comments

@Simonl9l
Copy link

Simonl9l commented Mar 13, 2022

Description

If the dotnet-counters is launched for a process that has a number of custom metrics the displayed output be longer than the open console.

If attempts are then made to expand the length of the console the output is corrupted. with metrics instrument values show bad value till they are updated.

Also when those instruments have varying Measurement version (different metadata Key Value Pairs) the instrument name lines show values that were left from where that point of the screen was written to. These are never cleared making the output unreadable.

If the previous position had a larger value than is being emitted from latest observable data the higher order part of the displayed output are not overwritten with blank resulting gibberish.

Configuration

dotnet --info

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  12.2
 OS Platform: Darwin
 RID:         osx.12-arm64
 Base Path:   /usr/local/share/dotnet/sdk/6.0.101/

Host (useful for support):
  Version: 6.0.1
  Commit:  3a25a7f1cc

.NET SDKs installed:
  6.0.101 [/usr/local/share/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.1 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.1 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]

dotnet tool list --global            
Package Id           Version         Commands       
----------------------------------------------------
dotnet-counters      6.0.257301      dotnet-counters

Regression?

I've not see this work on any version to date.

@Simonl9l Simonl9l added the bug Something isn't working label Mar 13, 2022
@Simonl9l Simonl9l changed the title botnet-counter console output corruption on resize dotnet-counter console output corruption on resize Mar 13, 2022
@mikelle-rogers
Copy link
Member

Hi @Simonl9l, would you please provide me with a reproduction of the scenario you experienced?
I have root caused some other rendering issues dotnet-counters has, and with that fix, I ran a counters session like you described. I made my console short, I then ran dotnet-counters with a number of custom metrics that caused displayed output be longer than the open console. I then expanded the length of the console and everything still looked good.

In addition, I had a metric that was switching between 8,168 and 0 and the higher order part of the displayed output were overwritten with blanks so there was a clean console, rather than gibberish.

@Simonl9l
Copy link
Author

Simonl9l commented Apr 9, 2022

@mikelle-rogers apologies, its been a tad busy my end, thanks for looking a this.

Sorry can't real share a screenshot as info is proprietary.

Confirming that per the merge info seems to millstone for dot net 7, or is this going to be released on Nuget anytime soon.

@mikelle-rogers
Copy link
Member

@Simonl9l the new tools have been released. Will you please uninstall dotnet-counters (dotnet tool uninstall --global dotnet-counters) install dotnet-counters again, which by default installs the most recent version (dotnet tool install --global dotnet-counters), try locally reproducing your problem and let me know what happens?

@tommcdon tommcdon added this to the 7.0.0 milestone May 17, 2022
@mikelle-rogers
Copy link
Member

@davmason doesn't @dramos020's PR fix this?

@davmason
Copy link
Member

Yes, his PR does fix this issue. Closing.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working dotnet-counters
Projects
None yet
Development

No branches or pull requests

4 participants