-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python patch version updates #480
Comments
/fyi @garath 😦 |
!32884 is now merged. since this affects only OSX images as they're manually updated (nothing that rolls out on Wednesdays), we're done 😁 |
not sure why I reopened this. bet I was confused… |
shoot. I can see clearly now. fix had to be reverted. will come back together w/ fix for #436 |
together w/ #436 in one PR |
decided this isn't adding value being tracked separately from #436. it was a specific issue in an earlier try at a fix for that issue that was never actually complete |
In completing #436, I realized the changes to the
macos-python-3
artefact mean it will no-op when moving to a newer patch release of Python.Specifically, https://dev.azure.com/dnceng/internal/_git/dotnet-helix-machines?path=/artifacts/macos-python-3/macos-python-3.sh ignores the patch version.
The above check will also work incorrectly if a machine already has (say) Python 4.0 on it when the requested version is 3.5.
I intentionally coded this to no-op when a Python installation was unnecessary. I unfortunately thought the patch version didn't matter much and didn't think the condition through thoroughly. However, Python patches frequently contain at least important-sounding fixes.
Release Note Category
Release Note Description
Corrected a problem in the #436 fix to enable us to keep the installed Python version on OSX machines up to date w/ patch releases.
The text was updated successfully, but these errors were encountered: