Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python patch version updates #480

Closed
1 of 3 tasks
dougbu opened this issue Jul 31, 2023 · 6 comments
Closed
1 of 3 tasks

Support Python patch version updates #480

dougbu opened this issue Jul 31, 2023 · 6 comments
Assignees
Labels
Helix-Machines Asks to update images, to add new queues for new OSes, and maintenance of physical machines Ops - Service Maintenance Used to track issues related to maintaining the services .NET Eng Supports

Comments

@dougbu
Copy link
Member

dougbu commented Jul 31, 2023

In completing #436, I realized the changes to the macos-python-3 artefact mean it will no-op when moving to a newer patch release of Python.

Specifically, https://dev.azure.com/dnceng/internal/_git/dotnet-helix-machines?path=/artifacts/macos-python-3/macos-python-3.sh ignores the patch version.

if [ $major -lt $requestedMajor ] || [ $minor -lt $requestedMinor ]; then

The above check will also work incorrectly if a machine already has (say) Python 4.0 on it when the requested version is 3.5.

I intentionally coded this to no-op when a Python installation was unnecessary. I unfortunately thought the patch version didn't matter much and didn't think the condition through thoroughly. However, Python patches frequently contain at least important-sounding fixes.

Release Note Category

  • Feature changes/additions
  • Bug fixes
  • Internal Infrastructure Improvements

Release Note Description

Corrected a problem in the #436 fix to enable us to keep the installed Python version on OSX machines up to date w/ patch releases.

@dougbu
Copy link
Member Author

dougbu commented Jul 31, 2023

/fyi @garath 😦

@dougbu dougbu self-assigned this Jul 31, 2023
@dougbu dougbu added the Operations Used by FR to track issues related to operations work label Jul 31, 2023
@dougbu dougbu changed the title Support Python minor version updates Support Python patch version updates Jul 31, 2023
@dougbu dougbu added Ops - Service Maintenance Used to track issues related to maintaining the services .NET Eng Supports and removed Operations Used by FR to track issues related to operations work labels Jul 31, 2023
@dougbu
Copy link
Member Author

dougbu commented Aug 1, 2023

!32884 is now merged. since this affects only OSX images as they're manually updated (nothing that rolls out on Wednesdays), we're done 😁

@dougbu dougbu closed this as completed Aug 1, 2023
@dougbu dougbu reopened this Aug 4, 2023
@dougbu
Copy link
Member Author

dougbu commented Aug 15, 2023

not sure why I reopened this. bet I was confused…

@dougbu dougbu closed this as completed Aug 15, 2023
@dougbu
Copy link
Member Author

dougbu commented Aug 15, 2023

shoot. I can see clearly now. fix had to be reverted. will come back together w/ fix for #436

@dougbu
Copy link
Member Author

dougbu commented Aug 21, 2023

together w/ #436 in one PR

@ilyas1974 ilyas1974 added the Helix-Machines Asks to update images, to add new queues for new OSes, and maintenance of physical machines label Oct 17, 2023
@dougbu
Copy link
Member Author

dougbu commented Nov 3, 2023

decided this isn't adding value being tracked separately from #436. it was a specific issue in an earlier try at a fix for that issue that was never actually complete

@dougbu dougbu closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Helix-Machines Asks to update images, to add new queues for new OSes, and maintenance of physical machines Ops - Service Maintenance Used to track issues related to maintaining the services .NET Eng Supports
Projects
None yet
Development

No branches or pull requests

2 participants