Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown link check has an issue with some links even though they work fine #5872

Open
lbussell opened this issue Sep 10, 2024 · 2 comments
Open

Comments

@lbussell
Copy link
Contributor

I have noticed that the markdown link check Github action has issues with certain links, even though the links work correctly.

Both of the links Work On My Machine. This has been causing many valid PRs to appear as failing validation. I believe that retries have caused some of these to pass but I cannot confirm that.

Related: #5818
/cc @MichaelSimons

@lbussell
Copy link
Contributor Author

lbussell commented Sep 16, 2024

[Triage] There are configuration options that we could use here:

  1. Only enable Markdown checking on files that are modified in a PR
    • If so, then run against all files separately on a schedule
  2. Increase the number of automatic retries, or retry on more/different error codes
  3. Allow-list certain links to prevent them from being checked if we know they work (e.g. https://support.microsoft.com/contactus/)

@MichaelSimons
Copy link
Member

Another issue I just noticed is 429s when validating the Docker Hub links 😞.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Sprint
Development

No branches or pull requests

2 participants