Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite: Client-eval OrderBy() on DateTimeOffset, decimal, TimeSpan & ulong #11925

Closed
bricelam opened this issue May 7, 2018 · 9 comments · Fixed by #17191
Closed

SQLite: Client-eval OrderBy() on DateTimeOffset, decimal, TimeSpan & ulong #11925

bricelam opened this issue May 7, 2018 · 9 comments · Fixed by #17191
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@bricelam
Copy link
Contributor

bricelam commented May 7, 2018

#11889 updates <, <=, >, >=, MIN & MAX to client-eval on these types. Should we do the same for ORDER BY?

@ajcvickers
Copy link
Member

Triage: yes, do it for order-by.

@smitpatel
Copy link
Member

Presently SqlTranslatingExpressionVisitor does not have information about it is translating OrderBy terms. It would be breaking change to introduce it.

@ajcvickers ajcvickers added this to the 3.0.0 milestone Sep 24, 2018
@smitpatel
Copy link
Member

Possible duplicate of #10265

@bricelam
Copy link
Contributor Author

@smitpatel Are Average, Max, Min, and Sum regressed in 3.0? If not, I think we can punt this.

@smitpatel
Copy link
Member

Aggregate are not blocked right now. It can be done once we refactor for GroupBy aggregate support.

@divega divega removed this from the 3.0.0 milestone Jun 24, 2019
@divega
Copy link
Contributor

divega commented Jun 24, 2019

Clearing up milestone so we can decide what to do in triage.

@ajcvickers ajcvickers modified the milestone: 3.0.0 Jun 24, 2019
@Ignatella
Copy link

And TimeSpan OrderBy still does not work

@ajcvickers
Copy link
Member

@Ignatella Please file a new issue and attach a small, runnable project or post a small, runnable code listing that reproduces what you are seeing so that we can investigate.

@bricelam
Copy link
Contributor Author

@Ignatella After #18844, you could do .OrderBy(e => e.TimeSpan.TotalDays)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants