Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CoreTypeMapping.GenerateCodeLiteral to influence using directives #13799

Open
Tracked by #22948
ajcvickers opened this issue Oct 29, 2018 · 1 comment
Open
Tracked by #22948

Allow CoreTypeMapping.GenerateCodeLiteral to influence using directives #13799

ajcvickers opened this issue Oct 29, 2018 · 1 comment
Assignees
@roji
Labels
area-migrations area-scaffolding providers-beware punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Milestone
Backlog

Comments

@ajcvickers
Copy link
Member

See #13747

The expression tree for literals can contain use of arbitrary types and currently these need to be namespace-qualified because we can't ensure that the appropriate using directives are added to the file.

Note that this is non-trivial to fix, since currently we generate from the top down and don't know which literals we will be generating for.
@ajcvickers ajcvickers mentioned this issue Oct 29, 2018
Closed
@ajcvickers ajcvickers added this to the 3.0.0 milestone Oct 29, 2018
@ajcvickers
Copy link
Member Author

See also the case here: #13911 (comment)

@ajcvickers ajcvickers mentioned this issue Nov 20, 2018
Merged
@ajcvickers ajcvickers removed their assignment Jan 24, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Mar 8, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 7.0.0 Oct 22, 2021
@ajcvickers ajcvickers assigned roji and unassigned bricelam Oct 22, 2021
@AndriySvyryd AndriySvyryd mentioned this issue Jan 14, 2022
Open
48 tasks
@ajcvickers ajcvickers modified the milestones: 7.0.0, Backlog Apr 23, 2022
@ajcvickers ajcvickers added punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. and removed propose-punt labels Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-migrations area-scaffolding providers-beware punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@bricelam @ajcvickers @roji @AndriySvyryd