Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: we can uniquely identify keyless entities that have Distinct operation applied on them #26078

Open
Tracked by #30173
maumar opened this issue Sep 16, 2021 · 0 comments

Comments

@maumar
Copy link
Contributor

maumar commented Sep 16, 2021

Currently we have logic for Distinct/GroupBy to "salvage" identifiers, in case they are not part of the distinct projection / grouping key. In case of Distinct we simply can use the entire projection (unless it contains some complex expressions, see #26077), since it's now guaranteed to be unique, and in case of group by we use entire grouping key.

We should also be able to do this for keyless entities - they don't have identifiers so anytime we have a nested collection scenario involving them, we throw due to lack of identifiers needed to perform correct bucketing of the results. For now, we only do this trick if there were any identifiers to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants