Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevEng and Migrations: Consider testing schema roundtripability #3599

Closed
divega opened this issue Oct 29, 2015 · 3 comments
Closed

RevEng and Migrations: Consider testing schema roundtripability #3599

divega opened this issue Oct 29, 2015 · 3 comments
Labels
area-test closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.

Comments

@divega
Copy link
Contributor

divega commented Oct 29, 2015

While EF will always only understand about a subset of the database constructs,
we have done work to improve the fidelity of database reverse engineering, e.g. in #3579 we made sure that names of indexes were preserved in the model. From #2840 (comment):

Thinking on this some more. If we want the model to be as "round-trippable" as possible, we will need to specify at least the index's name for all indexes. The name we would otherwise generate through migrations is not likely to be the same as it depends on whatever tool the DBA used to create the index in the first place (@lajones)

I would like to propose that we deliberately test how good the experience is when the user:

  1. Points reverse engineering to an existing database to produce an EF model
  2. Points migrations using the resulting model back to the database to make changes

Note that I don't think the goal of this should be to achieve 100% fidelity but to understand the gaps and possibly identify low hanging fruit that we can tackle to improve both reverse engineering and migrations.

cc @Eilon

@divega
Copy link
Contributor Author

divega commented Oct 29, 2015

We could consider adding an automated end-to-end test for a database that we know roundtrips in this way. It could help detect regressions, but I am not sure about the cost/benefit.

@ErikEJ
Copy link
Contributor

ErikEJ commented Oct 29, 2015

Great idea, I will do that for the SQLCE provider!

@ajcvickers
Copy link
Member

Closing this for now, with the understanding that we will likely have similar things to test as part of update-model-from-database, and we should do what we need to do in the context of that feature.

@ajcvickers ajcvickers added closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. and removed propose-close labels Feb 17, 2018
@ajcvickers ajcvickers removed this from the Backlog milestone Feb 17, 2018
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.
Projects
None yet
Development

No branches or pull requests

6 participants