Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DbFunctions: Consider protected methods for discovering DbFunctionAttribute #9956

Closed
smitpatel opened this issue Oct 3, 2017 · 6 comments
Closed
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. type-bug
Milestone

Comments

@smitpatel
Copy link
Member

At present we have set of BindingFlags to discover methods for UDFs, they explicitly ignores protected methods. But the attribute based discovery should be done regardless of protection level.
The protection level restricts user's ability to use the method inside of the EF Query but if in some way user can use it then we should translate it.
One way to use the method is to pass in IQueryable to public method in DbContext which would apply logics from protected/private methods by calling them and return it. (or there is always reflection)

@ajcvickers
Copy link
Member

Note from triage: we should do this for any property--public, protected, internal, private.

@ajcvickers ajcvickers added the help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. label Oct 4, 2017
@ajcvickers ajcvickers added this to the 2.1.0 milestone Oct 4, 2017
@ajcvickers
Copy link
Member

@pmiddleton We would love a PR for this if you are up for it. 😸

@pmiddleton
Copy link
Contributor

Sounds good.

What about private and internal? Might as well find those as well while we are at it.

@smitpatel
Copy link
Member Author

As @ajcvickers said above, we want all of them :trollface:

@pmiddleton
Copy link
Contributor

Well that would me I would have to read the whole post :)

@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 19, 2017
@smitpatel
Copy link
Member Author

Fixed via 843929d

@bricelam bricelam added the good first issue This issue should be relatively straightforward to fix. label May 31, 2019
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview1, 2.1.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. type-bug
Projects
None yet
Development

No branches or pull requests

4 participants