Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer needs to warn on virtual methods #1985

Closed
tlakollo opened this issue Apr 21, 2021 · 0 comments · Fixed by #2046
Closed

Analyzer needs to warn on virtual methods #1985

tlakollo opened this issue Apr 21, 2021 · 0 comments · Fixed by #2046
Assignees
Milestone

Comments

@tlakollo
Copy link
Contributor

Currently, the RUC analyzer and RAF analyzer don't check for other virtual calls, for example:

// On one file
public virtual void VirtualMethod() => null

// On some other file
[RequiresAttributeFiles]
public override void VirtualMethod(){ 
   SomeCode
}

public void M1(){
    VirtualMethod(); //This doesnt warn on the analyzer
}

The behavior should be to warn on all implementations of the method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants