Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PublishReadyToRun has a negative impact on PublishTrimmed #677

Closed
Symbai opened this issue Jul 26, 2019 · 1 comment
Closed

PublishReadyToRun has a negative impact on PublishTrimmed #677

Symbai opened this issue Jul 26, 2019 · 1 comment
Assignees
Labels

Comments

@Symbai
Copy link

Symbai commented Jul 26, 2019

Using PublishTrimmed on a blank WPF project reduces the size from 305 to 243 while using PublishTrimmed in combination of PublishReadyToRun only reduces the size from 305 to 294. Is there room for improvement?

@sbomer
Copy link
Member

sbomer commented Oct 14, 2019

@Symbai the 3.0 SDK linker defaults are to root assemblies other than netcoreapp, which means that large frameworks like WPF will be rooted by the linker, and since WPF depends on a large part of netcoreapp, the size benefits for WPF apps if you use PublishReadyToRun are marginal out of the box. We're thinking about ways to improve this such as providing more aggressive linker options (see #624), though we need to be careful since even the conservative defaults are breaking some WPF apps. I'm closing this for now since I believe the ask is captured in various other work that we're tracking, but feel free to re-open if you have questions:

@sbomer sbomer closed this as completed Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants