Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete dead code related to AVX #780

Closed
danmoseley opened this issue Aug 30, 2018 · 3 comments
Closed

Delete dead code related to AVX #780

danmoseley opened this issue Aug 30, 2018 · 3 comments
Labels
enhancement New feature or request need info This issue needs more info before triage up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@danmoseley
Copy link
Member

Some of the original code relating to AVX and SSE is dead and can be deleted including

  • all of avx.cpp and avx.cs
  • functions in thunk.cs that exposed avx.cpp functions, eg MatMulDX

I checked in TLC as well and the above were only used by code in NeuralNetworks/*, which will not migrate to ML.NET.

I also notice some functions in sse.cs seem dead eg MeanOfSrc
@Ivanidzo4ka Ivanidzo4ka mentioned this issue Oct 15, 2018
Merged
@eerhardt eerhardt added the up-for-grabs A good issue to fix if you are trying to contribute to the project label Oct 15, 2018
@Zruty0
Copy link
Contributor

Zruty0 commented Oct 29, 2018 •
edited
Loading

@yaeldekel , do you have an objection? If not, we'll take it as a bug.

@Zruty0 Zruty0 added enhancement New feature or request need info This issue needs more info before triage labels Oct 29, 2018
@jwood803
Copy link
Contributor

@danmosemsft Is this still an issue? I looked through the code and I'm not seeing the dead code. I could just be missing it, though, but thought I would double check. 😄

@Anipik
Copy link
Contributor

Anipik commented Dec 27, 2018

I removed all of the dead code from cpumath library

@Anipik Anipik closed this as completed Dec 27, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request need info This issue needs more info before triage up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jwood803 @danmoseley @eerhardt @Anipik @Zruty0