Paths starting with ./ in DefaultItemExcludes are not properly handled

[lanfeust69]

This is probably a flaw in the implementation of FileMatcher.

Steps to reproduce

See here

msbuild /bl /p:WithDot=True

Expected behavior

None items should only contain the .git* files and ReadMe.md

Actual behavior

None items also include the bin and Data contents.

Environment data

msbuild /version output:
16.5.0.12403

OS info:
both Windows 10 and Ubuntu 19.10

[Forgind]

Thanks for bringing this to our attention. Having looked at your project file, I suspect the problem is that BaseOutputPath, despite what our documentation says, isn't properly supported. You might be interested in the PR to fix that here and the issue it references here. I'm going to close this in favor of that issue, but after we've resolved it, if you're still hitting this problem, let me know, and I can reopen this and dig deeper.

[Forgind]

BaseOutputPath isn't actually necessary. I'll look more soon.

[lanfeust69]

BaseOutputPath isn't actually necessary. I'll look more soon.

Indeed, the project just mentioned two cases where the issue could happen.

[rainersigwald]

@lanfeust69 It's reasonable to start supporting this, but the FileMatcher often expects exact string prefix matches, so dropping ./ is helpful today.