Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log MSBuild process locale #5356

Closed
KirillOsenkov opened this issue May 18, 2020 · 6 comments
Closed

Log MSBuild process locale #5356

KirillOsenkov opened this issue May 18, 2020 · 6 comments
Assignees
@KirillOsenkov
Labels
Area: Logging Good First Issue Self-contained issues good for first-time contributors. help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. Localization triaged

Comments

@KirillOsenkov
Copy link
Member

I often see binlogs in German, French, etc. but there's no way to easily get the language except for guessing.

If we want to properly parse localized binlogs we need to know the language. Since we already log the binlog path, process, arguments, etc. let's also log the current culture of MSBuild.exe.
@KirillOsenkov KirillOsenkov added Area: Logging Good First Issue Self-contained issues good for first-time contributors. Localization help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. labels May 18, 2020
@KirillOsenkov
Copy link
Member Author

See related: #1596

@KirillOsenkov
Copy link
Member Author

Same approach as in #2810

@KirillOsenkov
Copy link
Member Author

https://source.dot.net/#q=GetMessagesToLogInBuildLoggers

@KirillOsenkov
Copy link
Member Author

#5426

@KirillOsenkov KirillOsenkov self-assigned this Jun 16, 2020
@rainersigwald
Copy link
Member

Do we need more than #5426?

@KirillOsenkov
Copy link
Member Author

Nope

@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KirillOsenkov KirillOsenkov

Labels
Area: Logging Good First Issue Self-contained issues good for first-time contributors. help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. Localization triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KirillOsenkov @rainersigwald @AR-May