Better error detection in performance-setup.* scripts

[billwert]

Our runtime/release/5.0 pipelines were failing due to a failed git clone of the performance runtime. The scripts don't check any error values, so the failure was hidden until a failure later in the pipeline.

Output from the failed step (on Windows):

Generating script.
========================== Starting Command Output ===========================
"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'D:\workspace\_work\_temp\67ed7ba5-4f65-46f4-a625-e5ece51bffa3.ps1'"
warning: Could not find remote branch master to clone.
fatal: Remote branch master not found in upstream origin

-------------------------------------------------------------------------------
   ROBOCOPY     ::     Robust File Copy for Windows                              
-------------------------------------------------------------------------------

  Started : Monday, September 13, 2021 5:46:06 PM
   Source : D:\workspace\_work\1\s\Payload\performance\docs\
     Dest : D:\workspace\_work\1\s\workitem\

    Files : *.*
	    
  Options : *.* /DCOPY:DA /COPY:DAT /R:1000000 /W:30 

------------------------------------------------------------------------------

2021/09/13 17:46:06 ERROR 3 (0x00000003) Accessing Source Directory D:\workspace\_work\1\s\Payload\performance\docs\

[Tohron]

So what is the desired behavior for this issue? Is it performance-setup.sh in runtime logging the clone failure when it occurs?

[billwert]

It is performance-setup(.sh|.ps1) checking the error codes of things that it runs (like git, or anything else interesting) and simply returning a non-zero exit code so that the pipeline is marked as failed.