Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find All References - Showing razor__virtual.cs instead of actual References #9369

Open
garrettlondon1 opened this issue Oct 4, 2023 · 3 comments
Assignees
Labels
bug Something isn't working Razor triaged vscode
Milestone

Comments

@garrettlondon1
Copy link

garrettlondon1 commented Oct 4, 2023

Environment data

dotnet --info output: .net 7.0.401
VS Code version: latest
C# Extension version: 2.4.4

When looking for references in code behind file of a Blazor Server Razor component, I expect to be able to see all the references that are calling the method.

image

Using C# Extension 2.4.4

@dibarbet
Copy link
Member

dibarbet commented Oct 5, 2023

@davidwengier do we need to include the razor span mapping service on the Roslyn side here? Or should Razor be mapping these values via a middleware

@dibarbet dibarbet added bug Something isn't working Razor triaged labels Oct 5, 2023
@davidwengier
Copy link
Contributor

davidwengier commented Oct 5, 2023

We definitely don't have the Razor span mapping service, and that causes a bunch of limitations in various features. As far as I know we haven't talked about how and when we're going to try to address them. #6919 and #8845 are the tracking issues for it I guess, though thats more about when we switch to using source generators. VS Code is essentially already in that world, even though it doesn't use source generators :)

@davidwengier
Copy link
Contributor

davidwengier commented Oct 5, 2023

I'm going to move this to the Razor repo so we can better track with the bigger issues I linked above.

@davidwengier davidwengier transferred this issue from dotnet/vscode-csharp Oct 5, 2023
@ghost ghost added the untriaged label Oct 5, 2023
@phil-allen-msft phil-allen-msft added this to the 17.9 P1 milestone Oct 5, 2023
@ghost ghost removed the untriaged label Oct 5, 2023
@phil-allen-msft phil-allen-msft modified the milestones: 17.9 P1, 17.10 P1 Jan 5, 2024
@phil-allen-msft phil-allen-msft modified the milestones: 17.10 P1, 17.10 P2 Feb 13, 2024
@phil-allen-msft phil-allen-msft modified the milestones: 17.10 P2, 17.10 P3 Mar 11, 2024
@phil-allen-msft phil-allen-msft modified the milestones: 17.10 P3, 17.11 P2 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Razor triaged vscode
Projects
None yet
Development

No branches or pull requests

4 participants