Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The simplifier should simplify away ? annotations if in a nullable annotation disabled context #37178

Closed
jasonmalinowski opened this issue Jul 12, 2019 · 0 comments
Closed

The simplifier should simplify away ? annotations if in a nullable annotation disabled context #37178

jasonmalinowski opened this issue Jul 12, 2019 · 0 comments
Labels
Area-IDE Concept-Continuous Improvement New Language Feature - Nullable Reference Types Nullable Reference Types
Milestone
16.3

Comments

@jasonmalinowski
Copy link
Member

Once #36101 is complete, we're going to update the simplifier to disregard generated ? annotations on nullable reference types. We definitely want to be smarter in some cases (see #37177 as an example) but this is a minimum bar we need to do to keep refactorings working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Concept-Continuous Improvement New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
16.3
Development

No branches or pull requests
3 participants
@jasonmalinowski @gafter @jinujoseph