Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Targeting IDE layer projects to .Net Core #45534

Open
genlu opened this issue Jun 29, 2020 · 7 comments · May be fixed by #61234
Open

Targeting IDE layer projects to .Net Core #45534

genlu opened this issue Jun 29, 2020 · 7 comments · May be fixed by #61234
Assignees
@genlu @sharwell
Labels
Area-IDE Concept-OOP Related to out-of-proc Test-Gap Describes a specific feature or scenario that does not have test coverage
Milestone
17.6

Comments

@genlu
Copy link
Member

genlu commented Jun 29, 2020

So we can eventually switch Roslyn OOP process in VS to .Net Core version of servicehub

This also include unit tests.
@genlu genlu added Area-IDE Concept-OOP Related to out-of-proc labels Jun 29, 2020
@genlu genlu added this to the 16.8 milestone Jun 29, 2020
@genlu genlu mentioned this issue Jun 29, 2020
Closed
@genlu
Copy link
Member Author

genlu commented Jun 29, 2020 •
edited
Loading

#45115 "Remove the EditorFeatures.Wpf dependency from Remote.ServiceHub" is related to this. @sharwell I'm assigning the issue to you since you have been working working on this already.

@genlu
Copy link
Member Author

genlu commented Jul 8, 2020

@sharwell Are you planning to work on those tests projects too?

@sharwell
Copy link
Member

sharwell commented Jul 8, 2020

I am

@genlu genlu mentioned this issue Jul 8, 2020
Merged
@genlu
Copy link
Member Author

genlu commented Jul 8, 2020

This targeting test utility to Core #45793

@sharwell
Copy link
Member

sharwell commented Jul 8, 2020

Workspace tests: #45813

@genlu genlu modified the milestones: 16.8, 16.9 Sep 14, 2020
@jinujoseph jinujoseph modified the milestones: 16.9, 16.10 Mar 28, 2021
@genlu
Copy link
Member Author

genlu commented Jun 2, 2021

The main remaining task is to refactor IDE unittest at Feature and EditorFeatuer layer to run on coreclr.

@genlu genlu modified the milestones: 16.10, 17.0 Jun 2, 2021
@jinujoseph jinujoseph modified the milestones: 17.0, 17.1 Oct 11, 2021
@jmarolf jmarolf added the User Story A single user-facing feature. Can be grouped under an epic. label Dec 2, 2021
@pCYSl5EDgo pCYSl5EDgo mentioned this issue Jan 2, 2022
Closed
@genlu genlu added the Test-Gap Describes a specific feature or scenario that does not have test coverage label Jan 5, 2022
@genlu
Copy link
Member Author

genlu commented Jan 5, 2022

Keep this in 17.1 since this is used for tracking testonly change

@jmarolf jmarolf removed the User Story A single user-facing feature. Can be grouped under an epic. label Jan 6, 2022
@genlu genlu modified the milestones: 17.1, 17.2 Mar 14, 2022
@jinujoseph jinujoseph removed this from the 17.2 milestone May 5, 2022
@jinujoseph jinujoseph added this to the 17.3 milestone May 5, 2022
@genlu genlu linked a pull request Jun 2, 2022 that will close this issue
Test the EditorFeatures layer on net472 and net6.0-windows #61234
Open
@genlu genlu modified the milestones: 17.3, 17.4 Jul 26, 2022
@genlu genlu modified the milestones: 17.4, 17.6 Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@genlu genlu

@sharwell sharwell

Labels
Area-IDE Concept-OOP Related to out-of-proc Test-Gap Describes a specific feature or scenario that does not have test coverage
Projects
None yet
Milestone
17.6
Development

Successfully merging a pull request may close this issue.

Test the EditorFeatures layer on net472 and net6.0-windows sharwell/roslyn
4 participants
@genlu @sharwell @jmarolf @jinujoseph