From 93618ad2276856127eb39ebcbf777110baaeaf08 Mon Sep 17 00:00:00 2001 From: Steve Pfister Date: Thu, 28 May 2020 15:18:00 -0400 Subject: [PATCH] Add mono interpreter test leg to CI (#35568) This change enables the interpreter on CI as well as providing an option for the local test run. --- eng/pipelines/libraries/base-job.yml | 6 ++- .../libraries/helix-queues-setup.yml | 42 ++++++++++--------- eng/pipelines/libraries/helix.yml | 2 + eng/pipelines/libraries/run-test-job.yml | 9 +++- eng/pipelines/runtime.yml | 31 ++++++++++++++ eng/testing/tests.props | 6 +++ .../TestUtilities/System/PlatformDetection.cs | 1 + src/libraries/Directory.Build.props | 5 +++ .../tests/AssemblyInfo.cs | 8 ++++ .../tests/StringFormatTests.cs | 2 +- .../tests/System.Drawing.Common.Tests.csproj | 1 + .../tests/ServicePointManagerTest.cs | 1 + .../Marshal/ReadWrite/ByteTests.cs | 2 + .../Marshal/ReadWrite/Int16Tests.cs | 2 + .../Marshal/ReadWrite/Int32Tests.cs | 2 + .../Marshal/ReadWrite/Int64Tests.cs | 2 + .../Marshal/ReadWrite/IntPtrTests.cs | 2 + .../tests/BinaryFormatterTests.cs | 1 + .../tests/Serialization/Stream.Collections.cs | 1 + .../tests/AssemblyInfo.cs | 8 ++++ .../tests/System.Threading.Tasks.Tests.csproj | 1 + src/libraries/sendtohelix.proj | 4 +- src/mono/mono.proj | 1 + 23 files changed, 116 insertions(+), 24 deletions(-) create mode 100644 src/libraries/System.Drawing.Common/tests/AssemblyInfo.cs create mode 100644 src/libraries/System.Threading.Tasks/tests/AssemblyInfo.cs diff --git a/eng/pipelines/libraries/base-job.yml b/eng/pipelines/libraries/base-job.yml index b1a801f965789..0aa652b45ad37 100644 --- a/eng/pipelines/libraries/base-job.yml +++ b/eng/pipelines/libraries/base-job.yml @@ -17,6 +17,7 @@ parameters: variables: {} name: '' displayName: '' + testDisplayName: '' testScope: '' pool: '' @@ -93,7 +94,10 @@ jobs: - ${{ if or(ne(parameters.runtimeFlavor, 'coreclr'), ne(parameters.testScope, '')) }}: - _runtimeArtifactName: '$(runtimeFlavorName)Product_${{ parameters.runtimeVariant}}_${{ parameters.osGroup }}${{ parameters.osSubgroup }}_${{ parameters.archType }}_${{ parameters.liveRuntimeBuildConfig }}' - _runtimeArtifactsPathArg: ' /p:RuntimeArtifactsPath=$(_runtimeDownloadPath)' - - _testRunNamePrefixSuffix: $(runtimeFlavorName)_${{ parameters.liveRuntimeBuildConfig }} + - ${{ if eq(parameters.testDisplayName, '') }}: + - _testRunNamePrefixSuffix: $(runtimeFlavorName)_${{ parameters.liveRuntimeBuildConfig }} + - ${{ if ne(parameters.testDisplayName, '') }}: + - _testRunNamePrefixSuffix: ${{ parameters.testDisplayName }} # Windows variables - ${{ if eq(parameters.osGroup, 'Windows_NT') }}: diff --git a/eng/pipelines/libraries/helix-queues-setup.yml b/eng/pipelines/libraries/helix-queues-setup.yml index 7e450f8f4c0d0..5006775df7d17 100644 --- a/eng/pipelines/libraries/helix-queues-setup.yml +++ b/eng/pipelines/libraries/helix-queues-setup.yml @@ -50,26 +50,30 @@ jobs: # Linux x64 - ${{ if eq(parameters.platform, 'Linux_x64') }}: - - ${{ if eq(parameters.jobParameters.isFullMatrix, true) }}: - - Centos.7.Amd64.Open - - RedHat.7.Amd64.Open - - Debian.9.Amd64.Open - - Ubuntu.1604.Amd64.Open - - Ubuntu.1804.Amd64.Open - - SLES.12.Amd64.Open - - SLES.15.Amd64.Open - - (Fedora.30.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-30-helix-4f8cef7-20200121150022 - - (Fedora.32.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-32-helix-20200512010618-efb9f14 - - (Ubuntu.1910.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-19.10-helix-amd64-cfcfd50-20191030180623 - - (Debian.10.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-10-helix-amd64-bfcd90a-20200121150006 - - ${{ if eq(parameters.jobParameters.isFullMatrix, false) }}: - - Centos.7.Amd64.Open - - RedHat.7.Amd64.Open + - ${{ if eq(parameters.jobParameters.interpreter, '') }}: + - ${{ if eq(parameters.jobParameters.isFullMatrix, true) }}: + - Centos.7.Amd64.Open + - RedHat.7.Amd64.Open + - Debian.9.Amd64.Open + - Ubuntu.1604.Amd64.Open + - Ubuntu.1804.Amd64.Open + - SLES.12.Amd64.Open + - SLES.15.Amd64.Open + - (Fedora.30.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-30-helix-4f8cef7-20200121150022 + - (Fedora.32.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-32-helix-20200512010618-efb9f14 + - (Ubuntu.1910.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-19.10-helix-amd64-cfcfd50-20191030180623 + - (Debian.10.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-10-helix-amd64-bfcd90a-20200121150006 + - ${{ if eq(parameters.jobParameters.isFullMatrix, false) }}: + - Centos.7.Amd64.Open + - RedHat.7.Amd64.Open + - Debian.9.Amd64.Open + - Ubuntu.1604.Amd64.Open + - Ubuntu.1804.Amd64.Open + - SLES.15.Amd64.Open + - (Fedora.30.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-30-helix-4f8cef7-20200121150022 + - ${{ if eq(parameters.jobParameters.interpreter, 'true') }}: + # Limiting interp runs as we don't need as much coverage. - Debian.9.Amd64.Open - - Ubuntu.1604.Amd64.Open - - Ubuntu.1804.Amd64.Open - - SLES.15.Amd64.Open - - (Fedora.30.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-30-helix-4f8cef7-20200121150022 # OSX x64 - ${{ if eq(parameters.platform, 'OSX_x64') }}: diff --git a/eng/pipelines/libraries/helix.yml b/eng/pipelines/libraries/helix.yml index 66b52f0197245..10e4550bd64f9 100644 --- a/eng/pipelines/libraries/helix.yml +++ b/eng/pipelines/libraries/helix.yml @@ -9,6 +9,7 @@ parameters: targetOS: '' testRunNamePrefixSuffix: '' testScope: 'innerloop' # innerloop | outerloop | all + interpreter: '' condition: always() extraHelixArguments: '' @@ -20,6 +21,7 @@ steps: /p:TargetArchitecture=${{ parameters.archGroup }} /p:Configuration=${{ parameters.configuration }} /p:TargetOS=${{ parameters.targetOS }} + /p:MonoEnableInterpreter=${{ parameters.interpreter }} /p:TestScope=${{ parameters.testScope }} /p:TestRunNamePrefixSuffix=${{ parameters.testRunNamePrefixSuffix }} /p:HelixBuild=$(Build.BuildNumber) diff --git a/eng/pipelines/libraries/run-test-job.yml b/eng/pipelines/libraries/run-test-job.yml index 053d7f90044ae..9a82eadc50d0d 100644 --- a/eng/pipelines/libraries/run-test-job.yml +++ b/eng/pipelines/libraries/run-test-job.yml @@ -7,6 +7,8 @@ parameters: isOfficialBuild: false liveRuntimeBuildConfig: '' runtimeFlavor: 'coreclr' + runtimeDisplayName: 'coreclr' + interpreter: '' timeoutInMinutes: 150 pool: '' runtimeVariant: '' @@ -35,11 +37,13 @@ jobs: pool: ${{ parameters.pool }} testScope: ${{ parameters.testScope }} ${{ if ne(parameters.liveRuntimeBuildConfig, '') }}: - displayName: ${{ format('Test Run {0} {1}', parameters.liveRuntimeBuildConfig, parameters.runtimeFlavor) }} - name: ${{ format('test_run_{0}_{1}', parameters.liveRuntimeBuildConfig, parameters.runtimeFlavor) }} + displayName: ${{ format('Test Run {0} {1}', parameters.liveRuntimeBuildConfig, parameters.runtimeDisplayName) }} + name: ${{ format('test_run_{0}_{1}', parameters.liveRuntimeBuildConfig, parameters.runtimeDisplayName) }} ${{ if eq(parameters.liveRuntimeBuildConfig, '') }}: displayName: 'Test Run' name: test_run + ${{ if eq(parameters.interpreter, 'true') }}: + testDisplayName: ${{ parameters.runtimeFlavor }}_interpreter_${{ parameters.liveRuntimeBuildConfig }} dependsOn: - ${{ if notIn(parameters.framework, 'allConfigurations', 'net472') }}: @@ -91,6 +95,7 @@ jobs: msbuildScript: $(_msbuildCommand) framework: ${{ parameters.framework }} testScope: ${{ parameters.testScope }} + interpreter: ${{ parameters.interpreter }} creator: dotnet-bot helixToken: '' testRunNamePrefixSuffix: $(_testRunNamePrefixSuffix) diff --git a/eng/pipelines/runtime.yml b/eng/pipelines/runtime.yml index 056946c011bd2..4b4edc30a9c3d 100644 --- a/eng/pipelines/runtime.yml +++ b/eng/pipelines/runtime.yml @@ -826,6 +826,37 @@ jobs: jobParameters: isOfficialBuild: false isFullMatrix: ${{ variables.isFullMatrix }} + runtimeDisplayName: mono + testScope: innerloop + liveRuntimeBuildConfig: release + dependsOnTestBuildConfiguration: ${{ variables.debugOnPrReleaseOnRolling }} + dependsOnTestArchitecture: x64 + condition: >- + or( + eq(dependencies.checkout.outputs['SetPathVars_libraries.containsChange'], true), + eq(dependencies.checkout.outputs['SetPathVars_mono.containsChange'], true), + eq(variables['isFullMatrix'], true)) + +# +# Libraries Release Test Execution against a release mono interpreter runtime. +# Only when libraries or mono changed +# +- template: /eng/pipelines/common/platform-matrix.yml + parameters: + jobTemplate: /eng/pipelines/libraries/run-test-job.yml + runtimeFlavor: mono + buildConfig: ${{ variables.debugOnPrReleaseOnRolling }} + platforms: + # - Windows_NT_x64 + #- OSX_x64 + #- Linux_arm64 + - Linux_x64 + helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml + jobParameters: + isOfficialBuild: false + isFullMatrix: ${{ variables.isFullMatrix }} + interpreter: true + runtimeDisplayName: mono_interpreter testScope: innerloop liveRuntimeBuildConfig: release dependsOnTestBuildConfiguration: ${{ variables.debugOnPrReleaseOnRolling }} diff --git a/eng/testing/tests.props b/eng/testing/tests.props index cccce13b1c454..bf2f93fcceb39 100644 --- a/eng/testing/tests.props +++ b/eng/testing/tests.props @@ -33,6 +33,12 @@ + + + + + + + + --interpreter + + diff --git a/src/libraries/System.Drawing.Common/tests/AssemblyInfo.cs b/src/libraries/System.Drawing.Common/tests/AssemblyInfo.cs new file mode 100644 index 0000000000000..3420d3ba0e623 --- /dev/null +++ b/src/libraries/System.Drawing.Common/tests/AssemblyInfo.cs @@ -0,0 +1,8 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using System; +using Xunit; + +[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/35917", typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoInterpreter))] \ No newline at end of file diff --git a/src/libraries/System.Drawing.Common/tests/StringFormatTests.cs b/src/libraries/System.Drawing.Common/tests/StringFormatTests.cs index ad5f8907f6ed0..4ab9ddb47e085 100644 --- a/src/libraries/System.Drawing.Common/tests/StringFormatTests.cs +++ b/src/libraries/System.Drawing.Common/tests/StringFormatTests.cs @@ -84,7 +84,7 @@ public void Ctor_Format() } } - [Fact] + [ConditionalFact(Helpers.IsDrawingSupported)] public void Ctor_NullFormat_ThrowsArgumentNullException() { AssertExtensions.Throws("format", () => new StringFormat(null)); diff --git a/src/libraries/System.Drawing.Common/tests/System.Drawing.Common.Tests.csproj b/src/libraries/System.Drawing.Common/tests/System.Drawing.Common.Tests.csproj index 873e1e6dada7f..752aecda15a8e 100644 --- a/src/libraries/System.Drawing.Common/tests/System.Drawing.Common.Tests.csproj +++ b/src/libraries/System.Drawing.Common/tests/System.Drawing.Common.Tests.csproj @@ -5,6 +5,7 @@ $(NetCoreAppCurrent);$(NetFrameworkCurrent) + diff --git a/src/libraries/System.Net.ServicePoint/tests/ServicePointManagerTest.cs b/src/libraries/System.Net.ServicePoint/tests/ServicePointManagerTest.cs index b63c6c137d832..7c7a64a8cb06e 100644 --- a/src/libraries/System.Net.ServicePoint/tests/ServicePointManagerTest.cs +++ b/src/libraries/System.Net.ServicePoint/tests/ServicePointManagerTest.cs @@ -284,6 +284,7 @@ public static void FindServicePoint_ReturnsCachedServicePoint() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/36217", typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoInterpreter))] public static void FindServicePoint_Collectible() { RemoteExecutor.Invoke(() => diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs index 750dca4d26343..d204f07661285 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs @@ -132,6 +132,7 @@ public void ReadByte_StructWithReferenceTypes_ReturnsExpected() } [Fact] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadByte_ZeroPointer_ThrowsException() { AssertExtensions.ThrowsAny(() => Marshal.ReadByte(IntPtr.Zero)); @@ -159,6 +160,7 @@ public void ReadByte_NotReadable_ThrowsArgumentException() } [Fact] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteByte_ZeroPointer_ThrowsException() { AssertExtensions.ThrowsAny(() => Marshal.WriteByte(IntPtr.Zero, 0)); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs index 656fdffef1abf..286d33784271f 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs @@ -127,6 +127,7 @@ public void ReadInt16_StructWithReferenceTypes_ReturnsExpected() } [Fact] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt16_ZeroPointer_ThrowsException() { AssertExtensions.ThrowsAny(() => Marshal.ReadInt16(IntPtr.Zero)); @@ -154,6 +155,7 @@ public void ReadInt16_NotReadable_ThrowsArgumentException() } [Fact] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt16_ZeroPointer_ThrowsException() { AssertExtensions.ThrowsAny(() => Marshal.WriteInt16(IntPtr.Zero, 0)); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs index 42e0e7e64d525..3dd3cc2bd5a86 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs @@ -129,6 +129,7 @@ public void ReadInt32_StructWithReferenceTypes_ReturnsExpected() } [Fact] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt32_ZeroPoint_ThrowsException() { AssertExtensions.ThrowsAny(() => Marshal.ReadInt32(IntPtr.Zero)); @@ -156,6 +157,7 @@ public void ReadInt32_NotReadable_ThrowsArgumentException() } [Fact] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt32_ZeroPointer_ThrowsException() { AssertExtensions.ThrowsAny(() => Marshal.WriteInt32(IntPtr.Zero, 0)); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs index 01e78d2ace851..169896d161fb7 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs @@ -141,6 +141,7 @@ public void ReadInt64_StructWithReferenceTypes_ReturnsExpected() } [Fact] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt64_ZeroPointer_ThrowsException() { AssertExtensions.ThrowsAny(() => Marshal.ReadInt64(IntPtr.Zero)); @@ -168,6 +169,7 @@ public void ReadInt64_NotReadable_ThrowsArgumentException() } [Fact] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt64_ZeroPointer_ThrowsException() { AssertExtensions.ThrowsAny(() => Marshal.WriteInt64(IntPtr.Zero, 0)); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs index 6ecf6a028354b..e7a46cb5c76b6 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs @@ -136,6 +136,7 @@ public void ReadIntPtr_StructWithReferenceTypes_ReturnsExpected() } [Fact] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadIntPtr_ZeroPointer_ThrowsException() { AssertExtensions.ThrowsAny(() => Marshal.ReadIntPtr(IntPtr.Zero)); @@ -163,6 +164,7 @@ public void ReadIntPtr_NotReadable_ThrowsArgumentException() } [Fact] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteIntPtr_ZeroPointer_ThrowsException() { AssertExtensions.ThrowsAny(() => Marshal.WriteIntPtr(IntPtr.Zero, (IntPtr)0)); diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs index b24a9618534f7..cafbed1ecd9e8 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs @@ -24,6 +24,7 @@ public partial class BinaryFormatterTests : FileCleanupTestBase // On 32-bit we can't test these high inputs as they cause OutOfMemoryExceptions. [ConditionalTheory(typeof(Environment), nameof(Environment.Is64BitProcess))] [SkipOnCoreClr("Long running tests: https://github.com/dotnet/runtime/issues/11191", RuntimeConfiguration.Checked)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/35915", typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoInterpreter))] [InlineData(2 * 6_584_983 - 2)] // previous limit [InlineData(2 * 7_199_369 - 2)] // last pre-computed prime number public void SerializeHugeObjectGraphs(int limit) diff --git a/src/libraries/System.Text.Json/tests/Serialization/Stream.Collections.cs b/src/libraries/System.Text.Json/tests/Serialization/Stream.Collections.cs index 0cd7c170b7682..b90b50dba8ac0 100644 --- a/src/libraries/System.Text.Json/tests/Serialization/Stream.Collections.cs +++ b/src/libraries/System.Text.Json/tests/Serialization/Stream.Collections.cs @@ -18,6 +18,7 @@ namespace System.Text.Json.Serialization.Tests public static partial class StreamTests { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/35927", typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoInterpreter))] public static async Task HandleCollectionsAsync() { await RunTest(); diff --git a/src/libraries/System.Threading.Tasks/tests/AssemblyInfo.cs b/src/libraries/System.Threading.Tasks/tests/AssemblyInfo.cs new file mode 100644 index 0000000000000..25b898d55a160 --- /dev/null +++ b/src/libraries/System.Threading.Tasks/tests/AssemblyInfo.cs @@ -0,0 +1,8 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using System; +using Xunit; + +[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/35916", typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoInterpreter))] \ No newline at end of file diff --git a/src/libraries/System.Threading.Tasks/tests/System.Threading.Tasks.Tests.csproj b/src/libraries/System.Threading.Tasks/tests/System.Threading.Tasks.Tests.csproj index d123c71e67a98..53fe2520585d1 100644 --- a/src/libraries/System.Threading.Tasks/tests/System.Threading.Tasks.Tests.csproj +++ b/src/libraries/System.Threading.Tasks/tests/System.Threading.Tasks.Tests.csproj @@ -5,6 +5,7 @@ $(NetCoreAppCurrent) + diff --git a/src/libraries/sendtohelix.proj b/src/libraries/sendtohelix.proj index aba5711af7884..fc0f3f01ff4d8 100644 --- a/src/libraries/sendtohelix.proj +++ b/src/libraries/sendtohelix.proj @@ -3,7 +3,6 @@ $(BUILD_BUILDNUMBER) default - 1800 900 @@ -59,6 +58,9 @@ + set MONO_ENV_OPTIONS='$(MonoEnvOptions)' + export MONO_ENV_OPTIONS='$(MonoEnvOptions)' +