From 9d44b9bd4eddd5e523a44056c722bcc93bccca0e Mon Sep 17 00:00:00 2001
From: Eric StJohn <ericstj@microsoft.com>
Date: Mon, 23 Jan 2023 09:59:53 -0800
Subject: [PATCH] Update suppressions now that netframework facade has forwards
 (#79465)

* Update suppressions now that netframework facade has forwards

* Remove left/right constraint from suppression
---
 .../src/CompatibilitySuppressions.xml         | 245 +-----------------
 .../src/CompatibilitySuppressions.xml         |  75 ------
 2 files changed, 3 insertions(+), 317 deletions(-)
 delete mode 100644 src/libraries/System.Threading.AccessControl/src/CompatibilitySuppressions.xml

diff --git a/src/libraries/System.Security.Cryptography.Xml/src/CompatibilitySuppressions.xml b/src/libraries/System.Security.Cryptography.Xml/src/CompatibilitySuppressions.xml
index 7f5f1917a6b9e..4f60bbff6d578 100644
--- a/src/libraries/System.Security.Cryptography.Xml/src/CompatibilitySuppressions.xml
+++ b/src/libraries/System.Security.Cryptography.Xml/src/CompatibilitySuppressions.xml
@@ -1,248 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
+<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
 <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
-  <!-- Type must be public in implementation for serialization to work but we don't want to expose it publicly in the contract as it isn't public on .NET Framework. -->
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.CipherData</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.CipherReference</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
   <Suppression>
     <DiagnosticId>CP0001</DiagnosticId>
+    <!-- Type must be public in implementation for serialization to work but we don't want to expose it publicly in the contract as it isn't public on .NET Framework. -->
     <Target>T:System.Security.Cryptography.Xml.CryptoSignedXmlRecursionException</Target>
   </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.DataObject</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.DataReference</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.DSAKeyValue</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.EncryptedData</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.EncryptedKey</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.EncryptedReference</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.EncryptedType</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.EncryptedXml</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.EncryptionMethod</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.EncryptionProperty</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.EncryptionPropertyCollection</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.IRelDecryptor</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.KeyInfo</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.KeyInfoClause</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.KeyInfoEncryptedKey</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.KeyInfoName</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.KeyInfoNode</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.KeyInfoRetrievalMethod</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.KeyInfoX509Data</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.KeyReference</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.Reference</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.ReferenceList</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.RSAKeyValue</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.Signature</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.SignedInfo</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.SignedXml</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.Transform</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.TransformChain</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.XmlDecryptionTransform</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.XmlDsigBase64Transform</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.XmlDsigC14NTransform</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.XmlDsigC14NWithCommentsTransform</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.XmlDsigEnvelopedSignatureTransform</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.XmlDsigExcC14NTransform</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.XmlDsigExcC14NWithCommentsTransform</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.XmlDsigXPathTransform</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.XmlDsigXsltTransform</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.Cryptography.Xml.XmlLicenseTransform</Target>
-    <Left>lib/netstandard2.0/System.Security.Cryptography.Xml.dll</Left>
-    <Right>lib/net462/System.Security.Cryptography.Xml.dll</Right>
-  </Suppression>
-</Suppressions>
+</Suppressions>
\ No newline at end of file
diff --git a/src/libraries/System.Threading.AccessControl/src/CompatibilitySuppressions.xml b/src/libraries/System.Threading.AccessControl/src/CompatibilitySuppressions.xml
deleted file mode 100644
index fa8650e58d933..0000000000000
--- a/src/libraries/System.Threading.AccessControl/src/CompatibilitySuppressions.xml
+++ /dev/null
@@ -1,75 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.EventWaitHandleAccessRule</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.EventWaitHandleAuditRule</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.EventWaitHandleRights</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.EventWaitHandleSecurity</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.MutexAccessRule</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.MutexAuditRule</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.MutexRights</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.MutexSecurity</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.SemaphoreAccessRule</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.SemaphoreAuditRule</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.SemaphoreRights</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Security.AccessControl.SemaphoreSecurity</Target>
-    <Left>lib/netstandard2.0/System.Threading.AccessControl.dll</Left>
-    <Right>lib/net462/System.Threading.AccessControl.dll</Right>
-  </Suppression>
-</Suppressions>
\ No newline at end of file