Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasi] Align build configuration with NativeAOT-LLVM #100921

Open
2 of 4 tasks
maraf opened this issue Apr 11, 2024 · 5 comments
Open
2 of 4 tasks

[wasi] Align build configuration with NativeAOT-LLVM #100921

maraf opened this issue Apr 11, 2024 · 5 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm
Milestone

Comments

@maraf
Copy link
Member

maraf commented Apr 11, 2024

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm labels Apr 11, 2024
@maraf maraf added this to the 9.0.0 milestone Apr 11, 2024
@maraf maraf self-assigned this Apr 11, 2024
@SingleAccretion
Copy link
Contributor

NativeAOT-LLVM as it currently is doesn't use PublishAot (in fact, it doesn't work with it). See dotnet/runtimelab#2235 (comment).

Is the first item here, effectively, about making it work?

@lewing
Copy link
Member

lewing commented Apr 12, 2024

NativeAOT-LLVM as it currently is doesn't use PublishAot (in fact, it doesn't work with it). See dotnet/runtimelab#2235 (comment).

Is the first item here, effectively, about making it work?

We definitely need an msbuild gesture to distinguish between the build targets, it seems like PublishAot is the correct one right now but your feedback is welcome.

@maraf
Copy link
Member Author

maraf commented Apr 26, 2024

The most problematic thing with PublishAot=true is that we need to know "current" version of LLVM packages.
One way to tackle the problem and minify changes needed in the client's proj, is to produce a custom/nuget SDK,

  • It can disable mono workload
  • It can update @(KnownILCompilerPack)
  • So it could work with PublishAot=true
  • The only thing needed would be add restore feed

EDIT: Current plan is to integrate needed bits directly into mono workload manifest

@pavelsavara
Copy link
Member

why this is P0 ?

@maraf
Copy link
Member Author

maraf commented Jul 8, 2024

why this is P0 ?

Because lowering the barrier between two modes is important.

@maraf maraf modified the milestones: 9.0.0, 10.0.0 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Development

No branches or pull requests

4 participants