-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API Proposal]: [QUIC] Make CompleteWritesAsync #103434
Labels
Milestone
Comments
ManickaP
added
the
api-suggestion
Early API idea and discussion, it is NOT ready for implementation
label
Jun 13, 2024
dotnet-policy-service
bot
added
the
untriaged
New issue has not been triaged by the area owner
label
Jun 13, 2024
ManickaP
added
blocking
Marks issues that we want to fast track in order to unblock other important work
api-ready-for-review
API is ready for review, it is NOT ready for implementation
and removed
api-suggestion
Early API idea and discussion, it is NOT ready for implementation
untriaged
New issue has not been triaged by the area owner
labels
Jun 13, 2024
Tagging subscribers to this area: @dotnet/ncl |
Alternative 2: Delete the method? 😆 |
namespace System.Net.Quic;
// Existing class.
public class QuicStream : Stream
{
- public void CompleteWrites();
+ public ValueTask CompleteWritesAsync();
} |
bartonjs
added
api-approved
API was approved in API review, it can be implemented
and removed
blocking
Marks issues that we want to fast track in order to unblock other important work
api-ready-for-review
API is ready for review, it is NOT ready for implementation
labels
Jun 13, 2024
Closing as we decided to keep the API as-is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Background and motivation
System.Net.Quic is still in Preview, before we un-preview it, we'd like to change this method to an async one.
https://learn.microsoft.com/en-us/dotnet/api/system.net.quic.quicstream.completewrites?view=net-8.0
API Proposal
API Usage
Alternative Designs
Keeping it not-async and use existing
Task WritesClosed
property.Risks
No response
The text was updated successfully, but these errors were encountered: