Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: Regression in System.Buffers.Text.Tests.Base64EncodeDecodeInPlaceTests #105707

Open
performanceautofiler bot opened this issue Jul 30, 2024 · 5 comments
Assignees
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue TigerWindows
Baseline 6af853d7757e55a09fd9bc6dc1d6aa12c0b454f2
Compare b2b0db0c470eba512d358dcf3d359488083e82a8
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Buffers.Text.Tests.Base64EncodeDecodeInPlaceTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
395.24 ms 442.64 ms 1.12 0.01 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Buffers.Text.Tests.Base64EncodeDecodeInPlaceTests*'

System.Buffers.Text.Tests.Base64EncodeDecodeInPlaceTests.Base64DecodeInPlace(NumberOfBytes: 200000000)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@LoopedBard3
Copy link
Member

Comparison range: efebf20...eb765b7

@LoopedBard3 LoopedBard3 added untriaged New issue has not been triaged by the area owner and removed untriaged New issue has not been triaged by the area owner labels Jul 30, 2024
@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues Jul 30, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 30, 2024
@LoopedBard3
Copy link
Member

Likely: #105262 @buyaa-n

@LoopedBard3 LoopedBard3 changed the title [Perf] Windows/x64: 1 Regression on 7/26/2024 5:51:02 PM [Perf] Windows/x64: Regression in System.Buffers.Text.Tests.Base64EncodeDecodeInPlaceTests Jul 30, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

@adamsitnik adamsitnik removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 1, 2024
@buyaa-n buyaa-n added this to the 9.0.0 milestone Aug 1, 2024
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Aug 2, 2024
@buyaa-n
Copy link
Member

buyaa-n commented Aug 2, 2024

Likely: #105262 @buyaa-n

#105262 should not really impact this much, I will try to repro when I got time

@buyaa-n
Copy link
Member

buyaa-n commented Aug 14, 2024

#105262 should not really impact this much, I will try to repro when I got time

Surprisingly it was repro-ed locally, though there is nothing we can do for improving the changes made with #105262, the only change made for Base64.EncodeDecodeInPlace with the PR is
image
which should not impact the perf much.

Only thing I could try is review Base64.EncodeDecodeInPlace code entirely and try to improve the perf. So, I am gonna move this issue to v10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants