Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 1 Regression on 9/6/2024 10:52:37 PM #107625

Closed
performanceautofiler bot opened this issue Sep 10, 2024 · 4 comments
Closed

[Perf] Linux/x64: 1 Regression on 9/6/2024 10:52:37 PM #107625

performanceautofiler bot opened this issue Sep 10, 2024 · 4 comments
Assignees
Labels
arch-x64 needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline d4601d390b6ca9177d62a5ac29b74d30cc16d63d
Compare 5c4686f831d34c2c127e943d0f0d144793eeb0ad
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Text.Tests.Perf_StringBuilder

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
19.53 ns 21.61 ns 1.11 0.04 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.Tests.Perf_StringBuilder*'

System.Text.Tests.Perf_StringBuilder.ctor_capacity(length: 100)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Sep 10, 2024
@DrewScoggins DrewScoggins removed the untriaged New issue has not been triaged by the area owner label Sep 10, 2024
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Sep 10, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 10, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Sep 10, 2024
@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Sep 10, 2024
@DrewScoggins
Copy link
Member

Could be #107218

@AaronRobinsonMSFT
Copy link
Member

Yep. A 2 nanosecond regression here is acceptable.

@AaronRobinsonMSFT AaronRobinsonMSFT closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Sep 10, 2024
@stephentoub
Copy link
Member

What is the cause / connection with #107218 ?

@AaronRobinsonMSFT
Copy link
Member

We converted the GC.AllocateUninitializedArray<T>() to use a QCall in some instances. It is possible there will be a small regression in some cases. Two ns seems aboput right, but I could see it being "slightly" more in some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-x64 needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

3 participants