Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending IPC work items #12280

Closed
6 tasks done
jorive opened this issue Mar 16, 2019 · 4 comments
Closed
6 tasks done

Pending IPC work items #12280

jorive opened this issue Mar 16, 2019 · 4 comments
Assignees
@sywhang
Labels
area-Diagnostics-coreclr
Milestone
5.0.0

Comments

@jorive
Copy link
Member

jorive commented Mar 16, 2019

Pending IPC work items

  • Add tests
  • Add streaming functionality
  • Repurpose LF_REMOTING (currently used under the Diagnostics STRESS_LOG usage)
  • Replace the use of LOG under the Diagnostics Server with STRESS_LOG
  • Revisit the IPC mode of sending messages (byte vs message)
  • Handle shutdown on non-Windows platform (Need to unlink socket on the filesystem when the runtime exit with Ctrl-C/Ctrl-Break)
@jorive jorive self-assigned this Mar 16, 2019
jorive referenced this issue in dotnet/coreclr Apr 2, 2019
@jorive
[EventPipe] Streaming events out-of-proc using IPC (#23448)
40dda19 
- There was a race condition on EventPipe::Disable where we deallocated the s_pSession and set it to NULL, but there was still a thread waiting to write and dereference the null pointer. Now, we check that the session is not null.
- Added a new attach event to be handled to the Diagnostic server: Add streaming functionality (Syncronus) #23299
- On Linux, IPC was failing when delete was invoked because we were using new (std::nothrow) instead of new (nothrow) when allocating the newly connected clients/streams. I have replaced the call with new. This fixed #23580
- Move multiFileTraceLengthInSeconds out of the EventPipeSession.
- Unlink previously existing socket.
- EventPipeBlock: _ASSERTE was updated not to fail when data is not aligned if an error has already occurred.
- Update _ASSERTE in fastserializer.cpp to take into account the the write operation could have failed.
@josalem
Copy link
Contributor

josalem commented May 30, 2019

@jorive is this still tracking active work? It looks like we've completed everything in this list.

@jorive
Copy link
Member Author

jorive commented May 30, 2019

@josalem Not fully done yet. Ctrl-C needs to be properly fixed (need to look at what the debugger does), and add tests for all the new features.

@jorive jorive removed their assignment Aug 1, 2019
@jorive jorive changed the title [EventPipe] Pending IPC work items Pending IPC work items Aug 1, 2019
@sywhang
Copy link
Contributor

sywhang commented Aug 1, 2019

PR is out for cleaning up the socket on Ctrl-C: dotnet/coreclr#25976

@sywhang
Copy link
Contributor

sywhang commented Aug 7, 2019

dotnet/coreclr#25976 should check the last checkbox. Closing the issue as all checkboxes are marked as done.

@sywhang sywhang closed this as completed Aug 7, 2019
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sywhang sywhang

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
4 participants
@msftgits @jorive @josalem @sywhang