Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create implicit logging scopes from Activity.Tags #35209

Closed
shirhatti opened this issue Apr 20, 2020 · 5 comments
Closed

Create implicit logging scopes from Activity.Tags #35209

shirhatti opened this issue Apr 20, 2020 · 5 comments
Labels
area-Extensions-Logging documentation Documentation bug or enhancement, does not impact product or test code enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@shirhatti
Copy link
Contributor

Builds upon the work in #34305

This is a proposal to implicitly flow Activity.Tags to ILogger scopes by creating implicit logging scopes from Activity.Tags. Based on our offline discussion, we'll need to add an option to turn this on/off.

There is currently no consensus on whether this should be on by default.

In we decided not to do this, we'll at least need to provide guidance on the idiomatic way to do this.

@shirhatti shirhatti added enhancement Product code improvement that does NOT require public API changes/additions area-Extensions-Logging labels Apr 20, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Apr 20, 2020
@shirhatti
Copy link
Contributor Author

In the 5.0 timeframe, we'll provide guidance via docs on how to do this. We may reconsider in the future.

@shirhatti shirhatti added this to the Future milestone May 1, 2020
@tarekgh tarekgh added documentation Documentation bug or enhancement, does not impact product or test code and removed untriaged New issue has not been triaged by the area owner labels May 2, 2020
@maryamariyan
Copy link
Member

We are not going to provide this feature for now until we see a demand on it.

In we decided not to do this, we'll at least need to provide guidance on the idiomatic way to do this.

So therefore the next step for this issue is to provide documentation on adding Activity.Tags to logging.

@ericstj
Copy link
Member

ericstj commented Feb 4, 2021

@shirhatti @tarekgh @noahfalk do you have any update on this? Should it be considered for 6.0?

@tarekgh
Copy link
Member

tarekgh commented Feb 4, 2021

@ericstj we already have #46571 which is the feature requested currently marked for 6.0. I believe if we implement the requested feature will address the question in this issue. basically it will be opt-in choice to include the Tags (and the Baggage). We still discussing the feature though.

@tarekgh
Copy link
Member

tarekgh commented Mar 12, 2021

This is taken care of by the #48722

@tarekgh tarekgh closed this as completed Mar 12, 2021
@tarekgh tarekgh modified the milestones: Future, 6.0.0 Mar 12, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Logging documentation Documentation bug or enhancement, does not impact product or test code enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

5 participants