Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClientHandler._operationStarted is never set to true #38401

Closed
stephentoub opened this issue Jun 25, 2020 · 2 comments · Fixed by #38408
Closed

HttpClientHandler._operationStarted is never set to true #38401

stephentoub opened this issue Jun 25, 2020 · 2 comments · Fixed by #38408
Labels
area-System.Net.Http
Milestone
5.0.0

Comments

@stephentoub
Copy link
Member

If that's ok, it should be deleted. If it's not, the appropriate set needs to be added.
@stephentoub stephentoub added this to the 5.0.0 milestone Jun 25, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jun 25, 2020
@ManickaP
Copy link
Member

ManickaP commented Jun 25, 2020 •
edited
Loading

This might be remnant from Curl/WinHttpHandler removal... I'll scan the history and report back.
Nope, it wasn't used before the removals. It should get removed.

Originally moved from UAP handler code in: 247c84a#diff-108e2cc21fed31695657738cb1c81d67

@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label Jun 25, 2020
@ManickaP ManickaP mentioned this issue Jun 25, 2020
Merged
@stephentoub stephentoub mentioned this issue Jun 25, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net.Http
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Removed HttpClientHandler dead code and folded .Core file. ManickaP/runtime
3 participants
@stephentoub @ManickaP @Dotnet-GitSync-Bot