Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

superpmi: enable better % improvement number for asm diffs #41653

Closed
BruceForstall opened this issue Sep 1, 2020 · 0 comments · Fixed by #60124
Closed

superpmi: enable better % improvement number for asm diffs #41653

BruceForstall opened this issue Sep 1, 2020 · 0 comments · Fixed by #60124
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@BruceForstall
Copy link
Member

BruceForstall commented Sep 1, 2020 •
edited
Loading

Currently, when doing SuperPMI asm diffs, a % improvement/regressed number is calculated by jit-analyze using only the functions that contained diffs as the total amount of code. This gives skewed data, as we only generate the asm for functions that have any changes. We should calculate the diff using the total amount of code generated in the replay, whether it contained a diff or not.

category:eng-sys
theme:super-pmi
skill-level:beginner
cost:small
@BruceForstall BruceForstall added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 1, 2020
@BruceForstall BruceForstall added this to the 6.0.0 milestone Sep 1, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Sep 1, 2020
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Sep 1, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@BruceForstall BruceForstall removed the JitUntriaged CLR JIT issues needing additional triage label Nov 10, 2020
@BruceForstall BruceForstall self-assigned this Jan 27, 2021
@BruceForstall BruceForstall modified the milestones: 6.0.0, Future Mar 14, 2021
@BruceForstall BruceForstall removed their assignment Mar 14, 2021
@BruceForstall BruceForstall mentioned this issue May 18, 2021
Closed
@BruceForstall BruceForstall mentioned this issue Oct 7, 2021
Merged
@jakobbotsch jakobbotsch linked a pull request Oct 7, 2021 that will close this issue
Support passing total code size through when doing SPMI diffs #60124
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Support passing total code size through when doing SPMI diffs jakobbotsch/runtime
2 participants
@BruceForstall @Dotnet-GitSync-Bot