Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple System.Net.Http.Functional.Tests Timeouts #44339

Closed
steveisok opened this issue Nov 6, 2020 · 5 comments
Closed

Multiple System.Net.Http.Functional.Tests Timeouts #44339

steveisok opened this issue Nov 6, 2020 · 5 comments

Comments

@steveisok
Copy link
Member

First found in https://dev.azure.com/dnceng/public/_build/results?buildId=876982&view=logs&j=bf603221-817a-5f42-894a-9eb35c3c7f97&t=7b6c19b2-2655-5e8f-d26a-63d3381d63ae

Kusto indicates this suite has timed out 8 times today and 15 times in the last 10 days.

Jobs
| project JobId, Name, Source, Type, Build, Started, QueueName , Properties
| where Started >= ago(10d) 
| where Source contains "dotnet/runtime"
| join kind=inner
(WorkItems | project FriendlyName, JobId, Status, Finished - Started, ExitCode, FailCount
| where FriendlyName == "System.Net.Http.Functional.Tests" and Status == "Timeout") on JobId
@ghost
Copy link

ghost commented Nov 6, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Nov 6, 2020
@wfurt
Copy link
Member

wfurt commented Nov 6, 2020

It seems like predominantly conformance tests like

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-master-b77bac7807a8401d8d/System.Net.Http.Functional.Tests/console.dbce9eb1.log?sv=2019-07-07&se=2020-11-24T19%3A19%3A17Z&sr=c&sp=rl&sig=wPx%2BLzcadA%2B%2BS9%2FYAXBehSf65v%2FclxXb7xhNeIWjADM%3D

   System.Net.Http.Functional.Tests.SyncHttpHandler_HttpClientHandler_Authentication_Test.Credentials_DomainJoinedServerUsesKerberos_UseIpAddressAndHostHeader_Success [SKIP]
      Condition(s) not met: "IsDomainJoinedServerAvailable"
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:02:15
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:04:15
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:06:15
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:08:15
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:10:15
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:12:15
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:14:15

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-43535-merge-5f9bf3af761f4246b9/System.Net.Http.Functional.Tests/console.fac75075.log?sv=2019-07-07&se=2020-11-24T15%3A09%3A29Z&sr=c&sp=rl&sig=1VG8jDDnNWTXJRdLWfPnMISSrNtSQ1bJfftStkFNcVo%3D

    System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandlerTest.SendAsync_RequestVersion20_ResponseVersion20 [SKIP]
      Condition(s) not met: "IsWindows10Version1607OrGreater"
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.HttpClientTest.Send_TimeoutResponseContent_Throws', Elapsed: 00:03:47
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.HttpClientTest.Send_TimeoutResponseContent_Throws', Elapsed: 00:05:47
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.HttpClientTest.Send_TimeoutResponseContent_Throws', Elapsed: 00:07:47
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.HttpClientTest.Send_TimeoutResponseContent_Throws', Elapsed: 00:09:47
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.HttpClientTest.Send_TimeoutResponseContent_Throws', Elapsed: 00:11:47
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.HttpClientTest.Send_TimeoutResponseContent_Throws', Elapsed: 00:13:47

cc: @stephentoub @alnikola @antonfirsov

@stephentoub
Copy link
Member

It seems like predominantly conformance tests like

I checked in #44342 to hopefully help narrow down the ReadWriteAsync_Canceled_ThrowsOperationCanceledException issue. That could very well be a real product problem.

The other Send_TimeoutResponseContent_Throws one cited isn't in the stream tests. It looks to have one of the same problems I fixed recently in another test: if the client times out so fast that it never initiates a connection to the server, the server side and thus the whole test will hang.

@wfurt
Copy link
Member

wfurt commented Nov 6, 2020

Thanks for quick fix @stephentoub. I'll keep watching and we discussed to update our CI monitoring reports to see this sooner.

@wfurt
Copy link
Member

wfurt commented Nov 19, 2020

closing as it did not fail in master for 2 weeks.

@wfurt wfurt closed this as completed Nov 19, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants