Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COR_PRF_MONITOR_CODE_TRANSITIONS causes InvalidProgramException #45411

Closed
davmason opened this issue Dec 1, 2020 · 1 comment · Fixed by #45453
Closed

COR_PRF_MONITOR_CODE_TRANSITIONS causes InvalidProgramException #45411

davmason opened this issue Dec 1, 2020 · 1 comment · Fixed by #45453
Assignees
@davmason
Labels
area-Diagnostics-coreclr untriaged New issue has not been triaged by the area owner

Comments

@davmason
Copy link
Member

davmason commented Dec 1, 2020 •
edited
Loading

#43386 added some checks for illegal implicit casts in IL, after that went in COR_PRF_MONITOR_CODE_TRANSITIONS will trigger an InvalidProgramException.

I haven't debugged fully, but the likely cause is that NDirectStubLinker::EmitProfilerBeginTransitionCallback or NDirectStubLinker::EmitProfilerEndTransitionCallback (or both) have always emitted invalid IL and need to be fixed.
@davmason davmason self-assigned this Dec 1, 2020
@ghost
Copy link

ghost commented Dec 1, 2020

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

#44506 added some checks for illegal implicit casts in IL, after that went in COR_PRF_MONITOR_CODE_TRANSITIONS will trigger an InvalidProgramException.

I haven't debugged fully, but the likely cause is that NDirectStubLinker::EmitProfilerBeginTransitionCallback or NDirectStubLinker::EmitProfilerEndTransitionCallback (or both) have always emitted invalid IL and need to be fixed.

Author: davmason
Assignees: davmason
Labels:

area-Diagnostics-coreclr
Milestone: -

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 1, 2020
@davmason davmason mentioned this issue Dec 2, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davmason davmason

Labels
area-Diagnostics-coreclr untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix invalid IL in profiler stub helper davmason/runtime
2 participants
@davmason @Dotnet-GitSync-Bot