Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slicebuffers_success variant tests failing sporadically #47734

Closed
runfoapp bot opened this issue Feb 2, 2021 · 8 comments · Fixed by #48457
Closed

slicebuffers_success variant tests failing sporadically #47734

runfoapp bot opened this issue Feb 2, 2021 · 8 comments · Fixed by #48457
Assignees
@antonfirsov
Labels
area-System.Net.Sockets disabled-test The test is disabled in source code against the issue os-mac-os-x macOS aka OSX test-run-core Test failures in .NET Core test runs
Milestone
6.0.0

Comments

@runfoapp
Copy link

runfoapp bot commented Feb 2, 2021 •
edited
Loading

Runfo Tracking Issue: slicebuffers_success variant tests failing sporadically

Build Definition Kind Run Name
996179 runtime Rolling net6.0-OSX-Release-x64-CoreCLR_release-OSX.1014.Amd64.Open
995307 runtime PR 48305 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1014.Amd64.Open
994925 runtime PR 48298 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
994500 runtime PR 47950 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
994178 runtime PR 48276 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
994166 runtime Rolling net6.0-OSX-Release-x64-CoreCLR_release-OSX.1014.Amd64.Open
993140 runtime PR 48251 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
990000 runtime PR 48160 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
990000 runtime PR 48160 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
989340 runtime PR 48137 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1014.Amd64.Open
988913 runtime PR 47301 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
987631 runtime Rolling net6.0-OSX-Release-x64-CoreCLR_release-OSX.1015.Amd64.Open
987181 runtime PR 47829 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
987075 runtime PR 47519 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
986108 runtime PR 47842 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
985499 runtime PR 47938 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
982762 runtime PR 47906 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1014.Amd64.Open
982059 runtime Rolling net6.0-OSX-Release-x64-CoreCLR_release-OSX.1015.Amd64.Open
980951 runtime PR 47931 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
980917 runtime PR 47769 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1014.Amd64.Open
980061 runtime PR 47821 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
978549 runtime PR 47074 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
978280 runtime PR 47666 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
976514 runtime PR 47618 net6.0-OSX-Debug-x64-Mono_release-OSX.1015.Amd64.Open
974140 runtime Rolling net6.0-OSX-Release-x64-CoreCLR_release-OSX.1014.Amd64.Open
972359 runtime PR 47666 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1014.Amd64.Open
971460 runtime Rolling net6.0-OSX-Release-x64-Mono_release-OSX.1013.Amd64.Open
970980 runtime PR 43954 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
970460 runtime PR 47316 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 0
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 2, 2021
@ghost
Copy link

ghost commented Feb 2, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Tracking Issue: slicebuffers_success variant tests failing sporadically

Build Definition Kind Run Name
974140 runtime Rolling net6.0-OSX-Release-x64-CoreCLR_release-OSX.1014.Amd64.Open
972359 runtime PR 47666 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1014.Amd64.Open
971460 runtime Rolling net6.0-OSX-Release-x64-Mono_release-OSX.1013.Amd64.Open
970980 runtime PR 43954 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
970460 runtime PR 47316 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
1 5 5
Author: runfoapp[bot]
Assignees: -
Labels:

area-System.Net.Sockets, untriaged
Milestone: -

@hoyosjs hoyosjs removed the untriaged New issue has not been triaged by the area owner label Feb 2, 2021
@Anipik
Copy link
Contributor

Anipik commented Feb 8, 2021

Failed again https://dev.azure.com/dnceng/public/_build/results?buildId=982059&view=logs&j=05e92ac1-194e-59cf-664a-fa72d1cdd19b&t=caea1d4b-c90c-5be1-e57d-c4635079c333

@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 10, 2021 •
edited
Loading

Failed again in https://dev.azure.com/dnceng/public/_build/results?buildId=980951&view=ms.vss-test-web.build-test-results-tab&runId=30751418&resultId=136298&paneView=debug

Assert.Equal() Failure\nExpected: 100\nActual:   50
   at System.Net.Sockets.Tests.SendFile`1.SliceBuffers_Success() in /_/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs:line 226
--- End of stack trace from previous location ---

@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 10, 2021 •
edited
Loading

cc @dotnet/ncl

@karelz karelz added the os-mac-os-x macOS aka OSX label Feb 10, 2021
@karelz karelz added this to the 6.0.0 milestone Feb 10, 2021
@karelz karelz added the test-run-core Test failures in .NET Core test runs label Feb 10, 2021
@ViktorHofer ViktorHofer mentioned this issue Feb 10, 2021
Merged
@Anipik Anipik added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Feb 11, 2021
@runfoapp runfoapp bot mentioned this issue Feb 11, 2021
Closed
@geoffkizer
Copy link
Contributor

@antonfirsov This is a new test, right? I suspect the underlying issue isn't new, we've just never hit it before.

Regardless, we should investigate and fix.

@Anipik Anipik mentioned this issue Feb 18, 2021
Merged
@antonfirsov
Copy link
Member

antonfirsov commented Feb 18, 2021 •
edited
Loading

Yeah this is a new test introduced in #47479 which intends to test slicing for the new span overload from #47230.

The problem is not with the slicing itself but rather the fact that preBuffer and postBuffer are sent separately on Unix, and on Mac it seems to result in independent receives:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs

Lines 223 to 226 in 0ff4f4a

await SendFileAsync(client, null, preBuffer, postBuffer, TransmitFileOptions.UseDefaultWorkerThread);
byte[] receiveBuffer = new byte[100];
int receivedBytes = server.Receive(receiveBuffer);
Assert.Equal(100, receivedBytes);

Expecting to get all the sent data in a single receive was a mistake in #47479, I think we should not do it.

@antonfirsov antonfirsov mentioned this issue Feb 18, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 18, 2021
@antonfirsov antonfirsov self-assigned this Feb 18, 2021
@wfurt
Copy link
Member

wfurt commented Feb 18, 2021

yah. while singe receive may be common, we should not depend on it. I think we have examples in other tests.

@safern safern added disabled-test The test is disabled in source code against the issue and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Feb 19, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@antonfirsov antonfirsov

Labels
area-System.Net.Sockets disabled-test The test is disabled in source code against the issue os-mac-os-x macOS aka OSX test-run-core Test failures in .NET Core test runs
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fix Socket.SendFile test: SliceBuffers_Success antonfirsov/runtime
8 participants
@karelz @antonfirsov @ViktorHofer @Anipik @geoffkizer @wfurt @hoyosjs @safern