Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILLink SDK is defined in multiple places which causes Arcade validation builds to fail #48409

Closed
ViktorHofer opened this issue Feb 17, 2021 · 1 comment · Fixed by #48462
Closed

ILLink SDK is defined in multiple places which causes Arcade validation builds to fail #48409

ViktorHofer opened this issue Feb 17, 2021 · 1 comment · Fixed by #48462
Assignees
@ViktorHofer
Labels
area-Infrastructure-libraries blocking Marks issues that we want to fast track in order to unblock other important work
Milestone
6.0.0

Comments

@ViktorHofer
Copy link
Member

With dotnet/arcade@023bcee, the ILLinker is now referenced globally, similar to the compiler package. As the SDK doesn't allow to have multiple PackageReferences of the same Identitiy when IsImplicitlyDefined is set to true, the PackageReference in illink.targets should be removed.

This will unblock the Arcade validation builds: https://dev.azure.com/dnceng/internal/_build/results?buildId=998169&view=logs&j=316d5c15-0c50-544e-8051-e6b14a1ab674&t=68de0bee-b0ee-5e79-8d1a-c77a89225a17

C:\hostedtoolcache\windows\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(257,5): error NETSDK1023: A PackageReference for 'Microsoft.NET.ILLink.Tasks' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs [D:\a\1\s\Build.proj]
##[error]C:\hostedtoolcache\windows\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(257,5): error NETSDK1023: (NETCORE_ENGINEERING_TELEMETRY=Restore) A PackageReference for 'Microsoft.NET.ILLink.Tasks' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs
C:\hostedtoolcache\windows\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(257,5): error NETSDK1023: A PackageReference for 'Microsoft.NET.ILLink.Tasks' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs [D:\a\1\s\Build.proj]
##[error]C:\hostedtoolcache\windows\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(257,5): error NETSDK1023: (NETCORE_ENGINEERING_TELEMETRY=Restore) A PackageReference for 'Microsoft.NET.ILLink.Tasks' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs
C:\hostedtoolcache\windows\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(257,5): error NETSDK1023: A PackageReference for 'Microsoft.NET.ILLink.Tasks' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs [D:\a\1\s\Build.proj]
@ViktorHofer ViktorHofer added area-Infrastructure-libraries blocking Marks issues that we want to fast track in order to unblock other important work labels Feb 17, 2021
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Feb 17, 2021
@ViktorHofer ViktorHofer self-assigned this Feb 17, 2021
@ghost
Copy link

ghost commented Feb 17, 2021

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

With dotnet/arcade@023bcee, the ILLinker is now referenced globally, similar to the compiler package. As the SDK doesn't allow to have multiple PackageReferences of the same Identitiy when IsImplicitlyDefined is set to true, the PackageReference in illink.targets should be removed.

This will unblock the Arcade validation builds: https://dev.azure.com/dnceng/internal/_build/results?buildId=998169&view=logs&j=316d5c15-0c50-544e-8051-e6b14a1ab674&t=68de0bee-b0ee-5e79-8d1a-c77a89225a17

C:\hostedtoolcache\windows\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(257,5): error NETSDK1023: A PackageReference for 'Microsoft.NET.ILLink.Tasks' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs [D:\a\1\s\Build.proj]
##[error]C:\hostedtoolcache\windows\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(257,5): error NETSDK1023: (NETCORE_ENGINEERING_TELEMETRY=Restore) A PackageReference for 'Microsoft.NET.ILLink.Tasks' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs
C:\hostedtoolcache\windows\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(257,5): error NETSDK1023: A PackageReference for 'Microsoft.NET.ILLink.Tasks' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs [D:\a\1\s\Build.proj]
##[error]C:\hostedtoolcache\windows\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(257,5): error NETSDK1023: (NETCORE_ENGINEERING_TELEMETRY=Restore) A PackageReference for 'Microsoft.NET.ILLink.Tasks' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs
C:\hostedtoolcache\windows\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(257,5): error NETSDK1023: A PackageReference for 'Microsoft.NET.ILLink.Tasks' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs [D:\a\1\s\Build.proj]
Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries, blocking
Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 17, 2021
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Feb 17, 2021
ViktorHofer referenced this issue in dotnet/arcade Feb 17, 2021
@ViktorHofer
Add (IL)linker opt-in flag (#6936)
023bcee 
* Add (IL)linker opt-in flag
@ViktorHofer ViktorHofer mentioned this issue Feb 18, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 18, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 25, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries blocking Marks issues that we want to fast track in order to unblock other important work
Projects
None yet
Milestone
6.0.0
1 participant
@ViktorHofer