Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][aot] Figure out how to handle APIs not supported on AOT #53825

Closed
radical opened this issue Jun 7, 2021 · 5 comments
Closed

[wasm][aot] Figure out how to handle APIs not supported on AOT #53825

radical opened this issue Jun 7, 2021 · 5 comments
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono
Milestone

Comments

@radical
Copy link
Member

radical commented Jun 7, 2021

Some APIs, like Assembly.GetCallingAssembly() are not supported on wasm/AOT. We should have a clear behavior for this, eg. throw an exception, or maybe mark these APIs, so that the user is aware that these are not supported.

Example case: #53815

How is this handled for non-wasm+aot cases?

cc @vargaz @steveisok

@radical radical added the arch-wasm WebAssembly architecture label Jun 7, 2021
@ghost
Copy link

ghost commented Jun 7, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Some APIs, like Assembly.GetCallingAssembly() are not supported on wasm/AOT. We should have a clear behavior for this, eg. throw an exception, or maybe mark these APIs, so that the user is aware that these are not supported.

Example case: #53815

How is this handled for non-wasm+aot cases?

cc @vargaz @steveisok

Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 7, 2021
@steveisok
Copy link
Member

/cc @akoeplinger

@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Jun 14, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jun 15, 2021
@lewing
Copy link
Member

lewing commented Jun 17, 2021

We could make a mono AOT analyzer that look for attributes when AOT is enabled, I'm not sure there is a more general way to solve this. It would apply to mobile scenarios too.

@lewing
Copy link
Member

lewing commented Jun 17, 2021

#53815

@lewing lewing modified the milestones: 6.0.0, 7.0.0 Aug 17, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 11, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 20, 2022
@lewing lewing modified the milestones: 7.0.0, 8.0.0 Jul 25, 2022
@lewing lewing closed this as completed Jul 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants