Uri constructors accepting dontEscape have misleading Obsolete attribute

[jeffhandley]

There are 2 Uri constructors that are marked as obsolete, indicating the the dontEscape argument is deprecated and always false. Upon reviewing the code though, it seems the dontEscape argument is indeed utilized with potentially-true values.

        //
        // Uri(string, bool)
        //
        //  Uri constructor. Assumes that input string is canonically escaped
        //
        [Obsolete("This constructor has been deprecated; the dontEscape parameter is always false. Use Uri(string) instead.")]
        public Uri(string uriString, bool dontEscape)
        {
            if (uriString == null)
                throw new ArgumentNullException(nameof(uriString));

            CreateThis(uriString, dontEscape, UriKind.Absolute);
            DebugSetLeftCtor();
        }

        //
        // Uri(Uri, string, bool)
        //
        //  Uri combinatorial constructor. Do not perform character escaping if
        //  DontEscape is true
        //
        [Obsolete("This constructor has been deprecated; the dontEscape parameter is always false. Use Uri(Uri, string) instead.")]
        public Uri(Uri baseUri, string? relativeUri, bool dontEscape)
        {
            if (baseUri is null)
                throw new ArgumentNullException(nameof(baseUri));

            if (!baseUri.IsAbsoluteUri)
                throw new ArgumentOutOfRangeException(nameof(baseUri));

            CreateUri(baseUri, relativeUri, dontEscape);
            DebugSetLeftCtor();
        }

Originally posted by @jkotas in #56690 (comment)

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

There are 2 Uri constructors that are marked as obsolete, indicating the the dontEscape argument is deprecated and always false. Upon reviewing the code though, it seems the dontEscape argument is indeed utilized with potentially-true values.

        //
        // Uri(string, bool)
        //
        //  Uri constructor. Assumes that input string is canonically escaped
        //
        [Obsolete("This constructor has been deprecated; the dontEscape parameter is always false. Use Uri(string) instead.")]
        public Uri(string uriString, bool dontEscape)
        {
            if (uriString == null)
                throw new ArgumentNullException(nameof(uriString));

            CreateThis(uriString, dontEscape, UriKind.Absolute);
            DebugSetLeftCtor();
        }

        //
        // Uri(Uri, string, bool)
        //
        //  Uri combinatorial constructor. Do not perform character escaping if
        //  DontEscape is true
        //
        [Obsolete("This constructor has been deprecated; the dontEscape parameter is always false. Use Uri(Uri, string) instead.")]
        public Uri(Uri baseUri, string? relativeUri, bool dontEscape)
        {
            if (baseUri is null)
                throw new ArgumentNullException(nameof(baseUri));

            if (!baseUri.IsAbsoluteUri)
                throw new ArgumentOutOfRangeException(nameof(baseUri));

            CreateUri(baseUri, relativeUri, dontEscape);
            DebugSetLeftCtor();
        }

Originally posted by @jkotas in #56690 (comment)

Author:	jeffhandley
Assignees:	-
Labels:	area-System.Net, untriaged
Milestone:	-

[MihaZupan]

Triage: We should update the deprecated message, but these APis should never be used regardless.