Output unexpected literal string in MetricsEventSource.ParseSpecs

[itn3000]

Description

Some log message in MetricsEventSource seems to be unexpected literal string.
steps of reproduce are following.

1. run following code snippet

using System;
using System.Diagnostics.Metrics;

using var meter = new Meter("appmeter");
var counter = meter.CreateCounter<int>("counter1", "unit", "desc");
while(true)
{
    await Task.Delay(1000).ConfigureAwait(false);
    if(counter.Enabled)
    {
        counter.Add(1);
    }
}

2. listen MetricsEventSource with dotnet-trace collect -p [PID] --provideres System.Diagnostics.Metrics:::Metrics=appmeter
3. open trace file with perfview
4. view "System.Diagnostics.Metrics/Message" events

And there is record which has Message="Parsed metric: {spec}".
It should be Message="Parsed metric: appmeter".

Configuration

dotnet-sdk-6.0-rc1 windows10-x64

Other information

I found the source location which should be fixed.

runtime/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs

Lines 375 to 390 in 240a64d

	if (!MetricSpec.TryParse(specString, out MetricSpec spec))
	{
	Log.Message("Failed to parse metric spec: {specString}");
	}
	else
	{
	Log.Message("Parsed metric: {spec}");
	if (spec.InstrumentName != null)
	{
	_aggregationManager!.Include(spec.MeterName, spec.InstrumentName);
	}
	else
	{
	_aggregationManager!.Include(spec.MeterName);
	}
	}

[ghost]

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Some log message in MetricsEventSource seems to be unexpected literal string.
steps of reproduce are following.

1. run following code snippet

using System;
using System.Diagnostics.Metrics;

using var meter = new Meter("appmeter");
var counter = meter.CreateCounter<int>("counter1", "unit", "desc");
while(true)
{
    await Task.Delay(1000).ConfigureAwait(false);
    if(counter.Enabled)
    {
        counter.Add(1);
    }
}

2. listen MetricsEventSource with dotnet-trace collect -p [PID] --provideres System.Diagnostics.Metrics:::Metrics=appmeter
3. open trace file with perfview
4. view "System.Diagnostics.Metrics/Message" events

And there is record which has Message="Parsed metric: {spec}".
It should be Message="Parsed metric: appmeter".

Configuration

dotnet-sdk-6.0-rc1 windows10-x64

Other information

I found the source location which should be fixed.

runtime/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs

Lines 375 to 390 in 240a64d

	if (!MetricSpec.TryParse(specString, out MetricSpec spec))
	{
	Log.Message("Failed to parse metric spec: {specString}");
	}
	else
	{
	Log.Message("Parsed metric: {spec}");
	if (spec.InstrumentName != null)
	{
	_aggregationManager!.Include(spec.MeterName, spec.InstrumentName);
	}
	else
	{
	_aggregationManager!.Include(spec.MeterName);
	}
	}

Author:	itn3000
Assignees:	-
Labels:	area-System.Diagnostics.Tracing, untriaged
Milestone:	-

[itn3000]

I made branch and commit for fixing it, not write test yet.
itn3000@81d5fa5

[tommcdon]

@tarekgh

[tarekgh]

@itn3000 thanks for your report. do you want to submit a PR to fix it? it should be a trivial fix

- Log.Message("Failed to parse metric spec: {specString}"); 
+ Log.Message($"Failed to parse metric spec: {specString}"); 

and

-Log.Message("Parsed metric: {spec}");
+Log.Message($"Parsed metric: {spec}");

I looked at the rest of the file and couldn't find any other similar case.

CC @noahfalk

[itn3000]

I create PR #60176

[kasperk81]

a bug was found in a new API introduced in 6.0, should it be in 6.0 milestone (akin #60182)?