Avoid need for pragma warning disables in Regex source generator

[stephentoub]

The Regex source generator currently emits this at the beginning of the generated file:

#pragma warning disable CS0162 // Unreachable code
#pragma warning disable CS0164 // Unreferenced label
#pragma warning disable CS0168 // Variable declared but never used
#pragma warning disable CS0219 // Variable assigned but never used

It would be nice (but not required) to avoid the need for these by changing the code generator to not emit the patterns causing these warnings to fire, e.g. variables that are emitted in case they're needed but sometimes aren't, labels emitted out of convenience but sometimes aren't needed, etc. These shouldn't be a performance issue, as they're weeded out by the C# compiler at build time, but these patterns make the code a bit less readable.

[ghost]

Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The Regex source generator currently emits this at the beginning of the generated file:

#pragma warning disable CS0162 // Unreachable code
#pragma warning disable CS0164 // Unreferenced label
#pragma warning disable CS0168 // Variable declared but never used
#pragma warning disable CS0219 // Variable assigned but never used

It would be nice (but not required) to avoid the need for these by changing the code generator to not emit the patterns causing these warnings to fire, e.g. variables that are emitted in case they're needed but sometimes aren't, labels emitted out of convenience but sometimes aren't needed, etc. These shouldn't be a performance issue, as they're weeded out by the C# compiler at build time, but these patterns make the code a bit less readable.

Author:	stephentoub
Assignees:	-
Labels:	area-System.Text.RegularExpressions
Milestone:	7.0.0

[stephentoub]

The pragma for CS0168 was removed in #62605

[stephentoub]

I'm going to close this. While it'd be nice to remove the three remaining pragmas, it would be difficult to do so well and simply isn't worth it.