Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move corerun to src/native/hosts/ #62512

Open
Tracked by #58266
lambdageek opened this issue Dec 8, 2021 · 3 comments
Open
Tracked by #58266

Move corerun to src/native/hosts/ #62512

lambdageek opened this issue Dec 8, 2021 · 3 comments
Labels
area-Infrastructure Bottom Up Work Not part of a theme, epic, or user story
Milestone

Comments

@lambdageek
Copy link
Member

lambdageek commented Dec 8, 2021

See the discussion in #43952 (comment), for example, as well as PR reviews here #62500 (review).

The idea is that since corerun and CoreShim are used by both CoreCLR and MonoVM for runtime testing, and are not really part of CoreCLR proper, they should move to the common location where other shared code resides.

There's a slight complication: the hosts depend on the CoreCLR cmake infrastructure (add_component, add_executable_clr, install_clr), so at least some of that infrastructure should move to a shared directory too.

Part of #58266

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Dec 8, 2021
@lambdageek lambdageek changed the title Move corerun to Move corerun to src/native/hosts/ Dec 8, 2021
@ghost
Copy link

ghost commented Dec 8, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

See the discussion in #43952 (comment), for example, as well as PR reviews here #62500 (review).

The idea is that since corerun and CoreShim are used by both CoreCLR and MonoVM and are not really part of CoreCLR, they should move to the common location where other shared code resides.

There's a slight complication: the hosts depend on the CoreCLR and cmake infrastructure (add_component, add_executable_clr, install_clr), so at least some of that infrastructure should move to a shared directory too.

Part of #58266

Author: lambdageek
Assignees: -
Labels:

area-Infrastructure, untriaged

Milestone: -

@lambdageek lambdageek added the Bottom Up Work Not part of a theme, epic, or user story label Dec 8, 2021
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Dec 8, 2021
@marek-safar marek-safar added this to the Future milestone Dec 8, 2021
@naricc naricc self-assigned this Dec 8, 2021
@SamMonoRT SamMonoRT assigned jandupej and unassigned naricc Mar 13, 2023
@SamMonoRT
Copy link
Member

Low priority

@SamMonoRT SamMonoRT assigned fanyang-mono and unassigned jandupej Oct 25, 2023
@fanyang-mono fanyang-mono removed their assignment Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure Bottom Up Work Not part of a theme, epic, or user story
Projects
Status: No status
Development

No branches or pull requests

6 participants