Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Changes at 12/15/2021 7:57:48 PM #63455

Closed
performanceautofiler bot opened this issue Jan 5, 2022 · 3 comments
Closed

[Perf] Changes at 12/15/2021 7:57:48 PM #63455

performanceautofiler bot opened this issue Jan 5, 2022 · 3 comments
Assignees
Labels
arch-arm64 area-ExceptionHandling-coreclr os-linux Linux OS (any supported distro) tenet-performance Performance related issue
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Architecture arm64
OS ubuntu 18.04
Baseline e233b7b5b00d9b80f155cd484e246dfc24fdf801
Compare 0c5e9e56912897af742a84464b829645278bc180
Diff Diff

Regressions in Exceptions.Handling

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ThrowAndCatch - Duration of single invocation 115.66 μs 149.39 μs 1.29 0.26 True

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'Exceptions.Handling*'

Payloads

Baseline
Compare

Histogram

Exceptions.Handling.ThrowAndCatch(kind: ReflectionSoftware)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 149.39291522108846 > 122.01453583107035.
IsChangePoint: Marked as a change because one of 12/15/2021 12:53:06 PM, 1/5/2022 6:46:20 PM falls between 12/6/2021 2:46:54 PM and 1/5/2022 6:46:20 PM.
IsRegressionStdDev: Marked as regression because -31.908252014298096 (T) = (0 -143030.70530083627) / Math.Sqrt((8578565.28640735 / (46)) + (30845166.263695396 / (66))) is less than -1.9817652821320164 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (46) + (66) - 2, .025) and -0.22009095803972706 = (117229.54289460367 - 143030.70530083627) / 117229.54289460367 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@kunalspathak kunalspathak transferred this issue from dotnet/perf-autofiling-issues Jan 6, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jan 6, 2022
@kunalspathak kunalspathak added arch-arm64 os-linux Linux OS (any supported distro) tenet-performance Performance related issue and removed untriaged New issue has not been triaged by the area owner labels Jan 6, 2022
@kunalspathak
Copy link
Member

Caused by #62092
@janvorli

@mangod9 mangod9 added this to the 7.0.0 milestone Jul 6, 2022
@mangod9 mangod9 modified the milestones: 7.0.0, 8.0.0 Aug 11, 2022
@janvorli
Copy link
Member

janvorli commented Aug 3, 2023

I am closing this as there is not much we can do about it and there was nothing obvious in the 3rd party libunwind changes that we've synced to that I would expect to be a culprit.

@janvorli janvorli closed this as completed Aug 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-ExceptionHandling-coreclr os-linux Linux OS (any supported distro) tenet-performance Performance related issue
Projects
None yet
Development

No branches or pull requests

4 participants