Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Group 5] Enable nullable annotations for System.Security.Cryptography.Xml #67197

Closed
SteveDunn opened this issue Mar 27, 2022 · 4 comments · Fixed by #67198
Closed

[Group 5] Enable nullable annotations for System.Security.Cryptography.Xml #67197

SteveDunn opened this issue Mar 27, 2022 · 4 comments · Fixed by #67198

Comments

@SteveDunn
Copy link
Contributor

This is a pre-requisite for nullable annotations to Microsoft.Extensions.Configuration.Xm as described in Annotate Microsoft.Extensions.* assemblies for nullable reference types

@dotnet-issue-labeler dotnet-issue-labeler bot added area-Meta untriaged New issue has not been triaged by the area owner labels Mar 27, 2022
@ghost
Copy link

ghost commented Mar 27, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a pre-requisite for nullable annotations to Microsoft.Extensions.Configuration.Xm as described in Annotate Microsoft.Extensions.* assemblies for nullable reference types

Author: SteveDunn
Assignees: -
Labels:

area-Meta, untriaged

Milestone: -

@SteveDunn SteveDunn changed the title [Group 5] Enable nullable annotations for System.Security.Cryptography [Group 5] Enable nullable annotations for System.Security.Cryptography.Xml Mar 27, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 27, 2022
@ghost
Copy link

ghost commented Apr 9, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a pre-requisite for nullable annotations to Microsoft.Extensions.Configuration.Xm as described in Annotate Microsoft.Extensions.* assemblies for nullable reference types

Author: SteveDunn
Assignees: -
Labels:

area-System.Security, untriaged, in-pr

Milestone: -

@jeffhandley jeffhandley removed the untriaged New issue has not been triaged by the area owner label Apr 9, 2022
@jeffhandley jeffhandley modified the milestones: 6.0.x, 7.0.0 Apr 9, 2022
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Jun 2, 2022
@jeffhandley
Copy link
Member

@krwq The relationship between this issue/PR and #73687 was unclear to me. I'm going to go ahead and move this issue to 8.0.0, but here's what I recommend:

  1. If Nullable annotations for System.Security.Cryptography.Xml #67198 gets merged in before the .NET 7 RC 1 snap on Monday, that will be nice! We can change this issue milestone back to 7.0.0.
  2. If not, but it gets merged in next week, we can consider requesting for it to be ported into the RC1 branch (and announce it as a breaking change if necessary).
  3. Otherwise, it will be part of .NET 8; I wouldn't want to introduce it in RC2.

@jeffhandley jeffhandley modified the milestones: 7.0.0, 8.0.0 Aug 13, 2022
@krwq
Copy link
Member

krwq commented Aug 23, 2022

8.0.0 is fine. The issue I fixed was found while adding annotations to S.S.C.Xml and made it confusing to annote that's the only relationship

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants