Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm-mt] place multi-threaded wasm build into separate artifacts folders #68506

Closed
lambdageek opened this issue Apr 25, 2022 · 6 comments
Closed
Assignees
Labels
Milestone

Comments

@lambdageek
Copy link
Member

lambdageek commented Apr 25, 2022

Build artifacts for the /p:WasmEnableThreads=true should go into a separate output folder. In other words it should be possible to build with /p:WasmEnableThreads=false in the same tree and without the build artifacts interfering with each other.

Needed by #68508

Part of #68162

@ghost
Copy link

ghost commented Apr 25, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: lambdageek
Assignees: -
Labels:

untriaged, area-Infrastructure-mono

Milestone: -

@lambdageek lambdageek changed the title place multi-threaded wasm build into separate artifacts folders [wasm-mt] place multi-threaded wasm build into separate artifacts folders Apr 25, 2022
@lambdageek lambdageek added the arch-wasm WebAssembly architecture label Apr 25, 2022
@ghost
Copy link

ghost commented Apr 25, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Build artifacts for the /p:WasmEnableThreads=true should go into a separate output folder. In other words it should be possible to build with /p:WasmEnableThreads=false in the same tree and without the build artifacts interfering with each other.

Part of #68162

Author: lambdageek
Assignees: -
Labels:

arch-wasm, untriaged, area-Infrastructure-mono

Milestone: -

@lambdageek
Copy link
Member Author

@steveisok @akoeplinger The initial wasm-mt PR landed; this is now the next issue for the runtime pack

@steveisok
Copy link
Member

@lambdageek Alex is working on moving cmake related items out of mono.proj and into its own file. That'll make it easier to build the runtime twice w/o a bunch of conditions / hacks.

@lewing lewing added this to the 7.0.0 milestone May 11, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label May 11, 2022
@lambdageek
Copy link
Member Author

Note that this needs to be somewhat general: for the /p:WasmEnablePerfTracing=true build we should also place its artifacts into an ep subfolder (tracking: #69268)

@lambdageek lambdageek mentioned this issue May 19, 2022
22 tasks
@lambdageek
Copy link
Member Author

This is done using MonoWasmBuildVariant=perftrace or MonoWasmBuildVariant=multithread in #71054 which also published runtime packs. (we decided to go with separate runtime packs for each variant)

@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants