[wasm] Int64 marshaling is corrupting data which could not fit JS Number

[pavelsavara]

Description

JavaScript Number is float64 type. Integers outside of Number.MAX_SAFE_INTEGER and Number.MIN_SAFE_INTEGER can't be represented.

Out current code from emscripten is

getValue

case 'i64': return HEAP32[((ptr)>>2)];

And setValue

case 'i64': (tempI64 = [value>>>0,(tempDouble=value,(+(Math.abs(tempDouble))) >= 1.0 ? (tempDouble > 0.0 ? ((Math.min((+(Math.floor((tempDouble)/4294967296.0))), 4294967295.0))|0)>>>0 : (~~((+(Math.ceil((tempDouble - +(((~~(tempDouble)))>>>0))/4294967296.0)))))>>>0) : 0)],HEAP32[((ptr)>>2)] = tempI64[0],HEAP32[(((ptr)+(4))>>2)] = tempI64[1]); break;

Reproduction Steps

Net 7.0 preview 4 and below on WASM.

Expected behavior

Use available 52 bits both directions and throw on overflow.
Give user option to marshal also as BigInt

Actual behavior

Value is trimmed to 32bits only.

Regression?

No

Known Workarounds

use double on C# side too.

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

JavaScript Number is float64 type. Integers outside of Number.MAX_SAFE_INTEGER and Number.MIN_SAFE_INTEGER can't be represented.

Out current code from emscripten is

getValue

case 'i64': return HEAP32[((ptr)>>2)];

And setValue

case 'i64': (tempI64 = [value>>>0,(tempDouble=value,(+(Math.abs(tempDouble))) >= 1.0 ? (tempDouble > 0.0 ? ((Math.min((+(Math.floor((tempDouble)/4294967296.0))), 4294967295.0))|0)>>>0 : (~~((+(Math.ceil((tempDouble - +(((~~(tempDouble)))>>>0))/4294967296.0)))))>>>0) : 0)],HEAP32[((ptr)>>2)] = tempI64[0],HEAP32[(((ptr)+(4))>>2)] = tempI64[1]); break;

Reproduction Steps

Net 7.0 preview 4 and below on WASM.

Expected behavior

Use available 52 bits both directions and throw on overflow.

Actual behavior

Value is trimmed to 32bits only.

Regression?

No

Known Workarounds

use double on C# side too.

Configuration

No response

Other information

No response

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:	-