Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert: slot_table[slot_index] == nullptr #73692

Closed
karelz opened this issue Aug 10, 2022 · 9 comments
Closed

Assert: slot_table[slot_index] == nullptr #73692

karelz opened this issue Aug 10, 2022 · 9 comments
Assignees
Labels
area-GC-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Milestone

Comments

@karelz
Copy link
Member

karelz commented Aug 10, 2022

Affected tests:

  • JIT\Regression\JitBlue\GitHub_27924\GitHub_27924\GitHub_27924.cmd
  • GC/Scenarios/FinalizeTimeout/FinalizeTimeout/FinalizeTimeout.sh

Recent regression (started on 8/9):

  • 8/11 status:
    • GitHub_27924.cmd - 5x failures in last 120 days (note the oldest 2 asserts are different on the same PR - that was specific to the PR)
    • FinalizeTimeout.sh - 10x failures in last 120 days (note the oldest 2 asserts are different on the same PR - that was specific to the PR) -- failures on 2x OSX.1200.ARM64.Open and 8x OSX.1200.Amd64.Open
Day Run Details
8/10 Rolling run 1933914 GitHub_27924.cmd - coreclr windows arm64 Checked no_tiered_compilation @ Windows.10.Arm64v8.Open
8/9 PR build 1933770 - PR #73605 GitHub_27924.cmd - coreclr windows x86 Checked no_tiered_compilation @ Windows.10.Amd64.Open
8/9 PR build 1932986 - PR #73661 FinalizeTimeout.sh - coreclr OSX arm64 Checked no_tiered_compilation @ OSX.1200.ARM64.Open
8/9 PR build 1933526 - PR #73670 GitHub_27924.cmd- coreclr windows arm64 Checked no_tiered_compilation @ Windows.10.Arm64v8.Open
7/21 2x PR build 1895796 - PR #72229 GitHub_27924.cmd - Unrelated assert committed_by_oh[oh] == committed
    JIT\Regression\JitBlue\GitHub_27924\GitHub_27924\GitHub_27924.cmd [FAIL]
      
      Assert failure(PID 10172 [0x000027bc], Thread: 6156 [0x180c]): slot_table[slot_index] == nullptr
      
      CORECLR! `dynamic atexit destructor for 'WKS::gc_heap::mark_queue'' + 0x3C (0x00007ff8`6189f42c)
      CORECLR! <lambda_d121dba8a4adeaf3a9819e48611155df>::operator() + 0x13C (0x00007ff8`617b20ec)
      CORECLR! _crt_seh_guarded_call<int>::operator()<<lambda_6a47f4c8fd0152770a780fc1d70204eb>,<lambda_d121dba8a4adeaf3a9819e48611155df> &,<lambda_6aaa2265f5b6a89667e7d7630012e97a> > + 0x34 (0x00007ff8`617b1804)
      CORECLR! _acrt_lock_and_call<<lambda_d121dba8a4adeaf3a9819e48611155df> > + 0x50 (0x00007ff8`617b1938)
      CORECLR! execute_onexit_table + 0x38 (0x00007ff8`617b2300)
      CORECLR! <lambda_6e4b09c48022b2350581041d5f6b0c4c>::operator() + 0xC0 (0x00007ff8`617af668)
      CORECLR! _crt_seh_guarded_call<void>::operator()<<lambda_d80eeec6fff315bfe5c115232f3240e3>,<lambda_6e4b09c48022b2350581041d5f6b0c4c> &,<lambda_2358e3775559c9db80273638284d5e45> > + 0x2C (0x00007ff8`617af33c)
      CORECLR! _acrt_lock_and_call<<lambda_6e4b09c48022b2350581041d5f6b0c4c> > + 0x50 (0x00007ff8`617af3a0)
      CORECLR! common_exit + 0x80 (0x00007ff8`617af8d0)
      CORECLR! cexit + 0x1C (0x00007ff8`617afc0c)
          File: D:\a\_work\1\s\src\coreclr\gc\gc.cpp Line: 23968
          Image: D:\h\w\ADC409C9\p\corerun.exe

Related to #73668

@karelz karelz added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Aug 10, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 10, 2022
@ghost
Copy link

ghost commented Aug 10, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Recent regression happened 3x in last <48 hours

  • Failures in Runfo in last 120 days (note the oldest 2 asserts are different on the same PR - that was specific to the PR)
Day Run Details
8/10 Rolling run 1933914 coreclr windows arm64 Checked no_tiered_compilation @ Windows.10.Arm64v8.Open
8/9 PR build 1933770 - PR #73605 coreclr windows x86 Checked no_tiered_compilation @ Windows.10.Amd64.Open
8/9 PR build 1933526 - PR #73670 coreclr windows arm64 Checked no_tiered_compilation @ Windows.10.Arm64v8.Open
7/21 2x PR build 1895796 - PR #72229 Unrelated assert committed_by_oh[oh] == committed
    JIT\Regression\JitBlue\GitHub_27924\GitHub_27924\GitHub_27924.cmd [FAIL]
      
      Assert failure(PID 10172 [0x000027bc], Thread: 6156 [0x180c]): slot_table[slot_index] == nullptr
      
      CORECLR! `dynamic atexit destructor for 'WKS::gc_heap::mark_queue'' + 0x3C (0x00007ff8`6189f42c)
      CORECLR! <lambda_d121dba8a4adeaf3a9819e48611155df>::operator() + 0x13C (0x00007ff8`617b20ec)
      CORECLR! _crt_seh_guarded_call<int>::operator()<<lambda_6a47f4c8fd0152770a780fc1d70204eb>,<lambda_d121dba8a4adeaf3a9819e48611155df> &,<lambda_6aaa2265f5b6a89667e7d7630012e97a> > + 0x34 (0x00007ff8`617b1804)
      CORECLR! _acrt_lock_and_call<<lambda_d121dba8a4adeaf3a9819e48611155df> > + 0x50 (0x00007ff8`617b1938)
      CORECLR! execute_onexit_table + 0x38 (0x00007ff8`617b2300)
      CORECLR! <lambda_6e4b09c48022b2350581041d5f6b0c4c>::operator() + 0xC0 (0x00007ff8`617af668)
      CORECLR! _crt_seh_guarded_call<void>::operator()<<lambda_d80eeec6fff315bfe5c115232f3240e3>,<lambda_6e4b09c48022b2350581041d5f6b0c4c> &,<lambda_2358e3775559c9db80273638284d5e45> > + 0x2C (0x00007ff8`617af33c)
      CORECLR! _acrt_lock_and_call<<lambda_6e4b09c48022b2350581041d5f6b0c4c> > + 0x50 (0x00007ff8`617af3a0)
      CORECLR! common_exit + 0x80 (0x00007ff8`617af8d0)
      CORECLR! cexit + 0x1C (0x00007ff8`617afc0c)
          File: D:\a\_work\1\s\src\coreclr\gc\gc.cpp Line: 23968
          Image: D:\h\w\ADC409C9\p\corerun.exe

Related to #73668

Author: karelz
Assignees: -
Labels:

area-CodeGen-coreclr, blocking-clean-ci

Milestone: -

@karelz
Copy link
Member Author

karelz commented Aug 10, 2022

Affects CI (more than 1x failure per day), we should disable the tests ASAP.

@jakobbotsch
Copy link
Member

Dup of #73679 and #73668?

@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Aug 10, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 10, 2022
@JulieLeeMSFT
Copy link
Member

@kunalspathak PTAL with high priority.

@kunalspathak
Copy link
Member

@JulieLeeMSFT - This is not a codegen issue but assert hit in GC code. #73679 is already assigned to @PeterSolMS.

@kunalspathak kunalspathak removed their assignment Aug 10, 2022
@ghost
Copy link

ghost commented Aug 11, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Recent regression happened 3x in last <48 hours

  • Failures in Runfo in last 120 days (note the oldest 2 asserts are different on the same PR - that was specific to the PR)
Day Run Details
8/10 Rolling run 1933914 coreclr windows arm64 Checked no_tiered_compilation @ Windows.10.Arm64v8.Open
8/9 PR build 1933770 - PR #73605 coreclr windows x86 Checked no_tiered_compilation @ Windows.10.Amd64.Open
8/9 PR build 1933526 - PR #73670 coreclr windows arm64 Checked no_tiered_compilation @ Windows.10.Arm64v8.Open
7/21 2x PR build 1895796 - PR #72229 Unrelated assert committed_by_oh[oh] == committed
    JIT\Regression\JitBlue\GitHub_27924\GitHub_27924\GitHub_27924.cmd [FAIL]
      
      Assert failure(PID 10172 [0x000027bc], Thread: 6156 [0x180c]): slot_table[slot_index] == nullptr
      
      CORECLR! `dynamic atexit destructor for 'WKS::gc_heap::mark_queue'' + 0x3C (0x00007ff8`6189f42c)
      CORECLR! <lambda_d121dba8a4adeaf3a9819e48611155df>::operator() + 0x13C (0x00007ff8`617b20ec)
      CORECLR! _crt_seh_guarded_call<int>::operator()<<lambda_6a47f4c8fd0152770a780fc1d70204eb>,<lambda_d121dba8a4adeaf3a9819e48611155df> &,<lambda_6aaa2265f5b6a89667e7d7630012e97a> > + 0x34 (0x00007ff8`617b1804)
      CORECLR! _acrt_lock_and_call<<lambda_d121dba8a4adeaf3a9819e48611155df> > + 0x50 (0x00007ff8`617b1938)
      CORECLR! execute_onexit_table + 0x38 (0x00007ff8`617b2300)
      CORECLR! <lambda_6e4b09c48022b2350581041d5f6b0c4c>::operator() + 0xC0 (0x00007ff8`617af668)
      CORECLR! _crt_seh_guarded_call<void>::operator()<<lambda_d80eeec6fff315bfe5c115232f3240e3>,<lambda_6e4b09c48022b2350581041d5f6b0c4c> &,<lambda_2358e3775559c9db80273638284d5e45> > + 0x2C (0x00007ff8`617af33c)
      CORECLR! _acrt_lock_and_call<<lambda_6e4b09c48022b2350581041d5f6b0c4c> > + 0x50 (0x00007ff8`617af3a0)
      CORECLR! common_exit + 0x80 (0x00007ff8`617af8d0)
      CORECLR! cexit + 0x1C (0x00007ff8`617afc0c)
          File: D:\a\_work\1\s\src\coreclr\gc\gc.cpp Line: 23968
          Image: D:\h\w\ADC409C9\p\corerun.exe

Related to #73668

Author: karelz
Assignees: -
Labels:

area-CodeGen-coreclr, area-GC-coreclr, blocking-clean-ci

Milestone: 7.0.0

@JulieLeeMSFT JulieLeeMSFT removed the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 11, 2022
@JulieLeeMSFT
Copy link
Member

Cc @mangod9 and @PeterSolMS for the GC issue.

@karelz karelz changed the title Assert: JIT\\Regression\\JitBlue\\GitHub_27924\\GitHub_27924\\GitHub_27924.cmd - slot_table[slot_index] == nullptr Assert: slot_table[slot_index] == nullptr Aug 11, 2022
@karelz
Copy link
Member Author

karelz commented Aug 11, 2022

I added 1 more affected test -- that one fails on OSX only.

@mangod9
Copy link
Member

mangod9 commented Aug 11, 2022

Fixed by #73761

@mangod9 mangod9 closed this as completed Aug 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-GC-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Projects
None yet
Development

No branches or pull requests

6 participants