Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 1 Regression on 10/13/2022 5:08:18 AM #78808

Closed
performanceautofiler bot opened this issue Oct 18, 2022 · 3 comments
Closed

[Perf] Linux/x64: 1 Regression on 10/13/2022 5:08:18 AM #78808

performanceautofiler bot opened this issue Oct 18, 2022 · 3 comments
Assignees
Labels
arch-x64 os-linux Linux OS (any supported distro)

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS ubuntu 18.04
Baseline f2de14d71ad44045dfa151d61ced3b91454acce8
Compare b8cab1cc0daf2b7fe491d0a68f5e450d79fbf982
Diff Diff

Regressions in System.Buffers.Text.Tests.Base64Tests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ConvertToBase64CharArray - Duration of single invocation 15.83 μs 20.32 μs 1.28 0.06 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Buffers.Text.Tests.Base64Tests*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Buffers.Text.Tests.Base64Tests.ConvertToBase64CharArray(NumberOfBytes: 1000)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 20.318128938802086 > 16.611089702187478.
IsChangePoint: Marked as a change because one of 8/5/2022 12:58:40 PM, 10/12/2022 7:36:52 PM, 10/18/2022 1:35:00 AM falls between 10/7/2022 6:01:23 PM and 10/18/2022 1:35:00 AM.
IsRegressionStdDev: Marked as regression because -28.791804090201865 (T) = (0 -20626.68543016371) / Math.Sqrt((72499.91733183233 / (31)) + (422450.6104425842 / (17))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (31) + (17) - 2, .025) and -0.2989749244567409 = (15879.202163036543 - 20626.68543016371) / 15879.202163036543 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added refs/heads/main untriaged New issue has not been triaged by the area owner labels Oct 18, 2022
@kotlarmilos
Copy link
Member

@stephentoub looks like the following PR created a regression - d337cba

I will also take a look

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@kotlarmilos kotlarmilos transferred this issue from dotnet/perf-autofiling-issues Nov 24, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@kotlarmilos
Copy link
Member

@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2022
@jeffhandley jeffhandley added os-linux Linux OS (any supported distro) arch-x64 and removed refs/heads/main labels Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 os-linux Linux OS (any supported distro)
Projects
None yet
Development

No branches or pull requests

2 participants