Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 1 Regression on 10/13/2022 10:51:15 PM #78809

Closed
performanceautofiler bot opened this issue Oct 18, 2022 · 5 comments
Closed

[Perf] Linux/x64: 1 Regression on 10/13/2022 10:51:15 PM #78809

performanceautofiler bot opened this issue Oct 18, 2022 · 5 comments
Assignees
Labels
arch-x64 os-linux Linux OS (any supported distro) PGO
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS ubuntu 18.04
Baseline fc0e636ea3af9b297441a9c9270298937f748300
Compare d4f078bf983b45554ac917e857fcacb785a53f3a
Diff Diff

Regressions in Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CreateInstance - Duration of single invocation 25.69 μs 27.69 μs 1.08 0.00 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark.CreateInstance


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 27.691086362480934 > 26.986456341054577.
IsChangePoint: Marked as a change because one of 10/13/2022 5:34:08 PM, 10/18/2022 1:35:00 AM falls between 10/7/2022 6:01:23 PM and 10/18/2022 1:35:00 AM.
IsRegressionStdDev: Marked as regression because -29.549336483561028 (T) = (0 -27800.16140104845) / Math.Sqrt((108450.77969472595 / (33)) + (42206.2108730837 / (15))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (33) + (15) - 2, .025) and -0.09053346084781927 = (25492.258971527222 - 27800.16140104845) / 25492.258971527222 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added PGO refs/heads/main untriaged New issue has not been triaged by the area owner labels Oct 18, 2022
@kotlarmilos
Copy link
Member

It is a regression - needs investigation

@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Oct 18, 2022
@kotlarmilos
Copy link
Member

@maryamariyan regression in f58cee2. Do you have any idea why it caused a regression in mono interpreter?

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@kotlarmilos kotlarmilos transferred this issue from dotnet/perf-autofiling-issues Nov 24, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@ghost
Copy link

ghost commented Nov 25, 2022

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS ubuntu 18.04
Baseline fc0e636ea3af9b297441a9c9270298937f748300
Compare d4f078bf983b45554ac917e857fcacb785a53f3a
Diff Diff

Regressions in Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CreateInstance - Duration of single invocation 25.69 μs 27.69 μs 1.08 0.00 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark.CreateInstance


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 27.691086362480934 > 26.986456341054577.
IsChangePoint: Marked as a change because one of 10/13/2022 5:34:08 PM, 10/18/2022 1:35:00 AM falls between 10/7/2022 6:01:23 PM and 10/18/2022 1:35:00 AM.
IsRegressionStdDev: Marked as regression because -29.549336483561028 (T) = (0 -27800.16140104845) / Math.Sqrt((108450.77969472595 / (33)) + (42206.2108730837 / (15))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (33) + (15) - 2, .025) and -0.09053346084781927 = (25492.258971527222 - 27800.16140104845) / 25492.258971527222 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: maryamariyan, kotlarmilos
Labels:

area-Extensions-DependencyInjection, refs/heads/main, ubuntu 18.04, PGO, Regression, x64

Milestone: -

@kotlarmilos
Copy link
Member

Fixed by #78840

@jeffhandley jeffhandley added os-linux Linux OS (any supported distro) arch-x64 and removed refs/heads/main labels Dec 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2023
@ericstj ericstj added this to the 8.0.0 milestone Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 os-linux Linux OS (any supported distro) PGO
Projects
None yet
Development

No branches or pull requests

5 participants