Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Failing test ApplyUpdateTests.AsyncMethodChanges #79043

Closed
lambdageek opened this issue Nov 30, 2022 · 0 comments · Fixed by #85182
Closed

[mono] Failing test ApplyUpdateTests.AsyncMethodChanges #79043

lambdageek opened this issue Nov 30, 2022 · 0 comments · Fixed by #85182
Assignees
@fanyang-mono
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc
Milestone
8.0.0

Comments

@lambdageek
Copy link
Member

lambdageek commented Nov 30, 2022 •
edited
Loading

(This is a test marked with an incorrect ActiveIssue - creating this one to track it separately, see #79044).

The test fails with:

        Mono: no implementation for interface method System.Runtime.CompilerServices.IAsyncStateMachine::MoveNext() in class System.Reflection.Metadata.ApplyUpdate.Test.AsyncMethodChange/<TestTaskMethod>d__1#1
        Mono: METHOD .ctor()
        Mono: METHOD MoveNext()
        Mono: METHOD SetStateMachine(System.Runtime.CompilerServices.IAsyncStateMachine)

It looks like we're not picking up the new async state machine's interface implementations from the hot reload delta.
@lambdageek lambdageek added the area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc label Nov 30, 2022
@lambdageek lambdageek added this to the 8.0.0 milestone Nov 30, 2022
@lambdageek lambdageek mentioned this issue Nov 30, 2022
Closed
27 tasks
@fanyang-mono fanyang-mono mentioned this issue Apr 21, 2023
Merged
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Apr 21, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fanyang-mono fanyang-mono

Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[mono] Add metadata update for overrides fanyang-mono/runtime
2 participants
@lambdageek @fanyang-mono