Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regressions in System.Globalization.Tests.StringEquality #79617

Closed
performanceautofiler bot opened this issue Dec 13, 2022 · 8 comments
Closed

Regressions in System.Globalization.Tests.StringEquality #79617

performanceautofiler bot opened this issue Dec 13, 2022 · 8 comments
Assignees
@dakersnar
Labels
area-GC-coreclr tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 21a8eb51ad181f6eb2d7f24d8eda34840025a8a0
Compare 0e6013077eba9e9dc2923c87ff3079cc65d2576e
Diff Diff

Regressions in System.Globalization.Tests.StringEquality

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Compare_DifferentFirstChar - Duration of single invocation 33.47 ns 39.16 ns 1.17 0.09 False
Compare_DifferentFirstChar - Duration of single invocation 32.55 ns 39.50 ns 1.21 0.05 False
Compare_DifferentFirstChar - Duration of single invocation 32.58 ns 39.22 ns 1.20 0.08 False
Compare_Same - Duration of single invocation 889.25 ns 1.46 μs 1.64 0.35 False
Compare_DifferentFirstChar - Duration of single invocation 35.96 ns 39.62 ns 1.10 0.08 False
Compare_DifferentFirstChar - Duration of single invocation 32.67 ns 38.97 ns 1.19 0.05 False

graph
graph
graph
graph
graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Globalization.Tests.StringEquality*'

Payloads

Baseline
Compare

Histogram

System.Globalization.Tests.StringEquality.Compare_DifferentFirstChar(Count: 1024, Options: (, None))

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 39.15915858054264 > 35.108778341417164.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 11/30/2022 12:23:56 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -16.620511958304334 (T) = (0 -39.00635150693171) / Math.Sqrt((4.320881813122062 / (56)) + (0.02181315417479187 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.14130528421530467 = (34.17696566063848 - 39.00635150693171) / 34.17696566063848 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Globalization.Tests.StringEquality.Compare_DifferentFirstChar(Count: 1024, Options: (, IgnoreCase))

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 39.49723524016647 > 34.641022538919614.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 11/30/2022 12:23:56 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -24.807956540349064 (T) = (0 -39.31121806448672) / Math.Sqrt((2.0804968091861418 / (56)) + (0.025963795814297193 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.15615391704311432 = (34.001716799979285 - 39.31121806448672) / 34.001716799979285 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Globalization.Tests.StringEquality.Compare_DifferentFirstChar(Count: 1024, Options: (en-US, IgnoreCase))

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 39.21587344423712 > 34.621688004413365.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 11/30/2022 12:23:56 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -17.565451883521696 (T) = (0 -39.22677078993461) / Math.Sqrt((4.3177269741104665 / (56)) + (0.00024716500128385923 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.14208217925022806 = (34.34671471337274 - 39.22677078993461) / 34.34671471337274 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Globalization.Tests.StringEquality.Compare_Same(Count: 1024, Options: (en-US, IgnoreCase))

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 1.4577780113353265 > 934.6009386052494.
IsChangePoint: Marked as a change because one of 10/19/2022 7:27:15 PM, 10/24/2022 10:11:47 PM, 12/5/2022 7:07:15 PM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -4.019217620487341 (T) = (0 -1131.576000808241) / Math.Sqrt((15412.532326399712 / (21)) + (80576.30181216789 / (38))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (21) + (38) - 2, .025) and -0.2342071550974721 = (916.844466615391 - 1131.576000808241) / 916.844466615391 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Globalization.Tests.StringEquality.Compare_DifferentFirstChar(Count: 1024, Options: (en-US, IgnoreNonSpace))

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 39.619518902658044 > 35.07207436327868.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 11/30/2022 12:23:56 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -20.652209199847032 (T) = (0 -39.36075565704459) / Math.Sqrt((2.4827599520775534 / (56)) + (0.05034755442913553 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.1490471949305536 = (34.25512531660937 - 39.36075565704459) / 34.25512531660937 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Globalization.Tests.StringEquality.Compare_DifferentFirstChar(Count: 1024, Options: (en-US, None))

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 38.96762614998606 > 34.94886401047151.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 11/30/2022 12:23:56 PM, 12/2/2022 5:21:30 AM, 12/2/2022 5:47:06 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -12.293413098086575 (T) = (0 -38.771407867530804) / Math.Sqrt((7.197616037102572 / (56)) + (0.02911100117769796 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.13364164615984075 = (34.20076176529609 - 38.771407867530804) / 34.20076176529609 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS Windows 10.0.19042
Baseline 21a8eb51ad181f6eb2d7f24d8eda34840025a8a0
Compare 0e6013077eba9e9dc2923c87ff3079cc65d2576e
Diff Diff

Regressions in System.Collections.Sort<String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Array_ComparerClass - Duration of single invocation 287.36 μs 315.65 μs 1.10 0.11 False
Array_ComparerStruct - Duration of single invocation 294.22 μs 319.74 μs 1.09 0.21 False

graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.Sort&lt;String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.Sort<String>.Array_ComparerClass(Size: 512)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 315.64525999999995 > 306.2055570000001.
IsChangePoint: Marked as a change because one of 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -3.5350393472228694 (T) = (0 -320130.9474920635) / Math.Sqrt((48488744.37244448 / (56)) + (139739652.10293117 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.08232319894158156 = (295781.2858535453 - 320130.9474920635) / 295781.2858535453 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Collections.Sort&lt;String&gt;.Array_ComparerStruct(Size: 512)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 319.7447613333333 > 309.02046685.
IsChangePoint: Marked as a change because one of 12/9/2022 8:25:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -3.3239285152786495 (T) = (0 -323355.2436194786) / Math.Sqrt((127238018.78475069 / (42)) + (698024517.9561676 / (17))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (42) + (17) - 2, .025) and -0.07325612162760624 = (301284.3226359672 - 323355.2436194786) / 301284.3226359672 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 21a8eb51ad181f6eb2d7f24d8eda34840025a8a0
Compare 0e6013077eba9e9dc2923c87ff3079cc65d2576e
Diff Diff

Regressions in System.Collections.ContainsKeyTrue<String, String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SortedList - Duration of single invocation 219.73 μs 249.86 μs 1.14 0.05 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.ContainsKeyTrue&lt;String, String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.ContainsKeyTrue<String, String>.SortedList(Size: 512)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 249.85857804232808 > 241.1767150421468.
IsChangePoint: Marked as a change because one of 9/29/2022 7:42:19 AM, 10/2/2022 11:57:04 PM, 11/23/2022 1:02:40 AM, 12/3/2022 7:24:45 AM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -14.533377066205812 (T) = (0 -249533.10764471834) / Math.Sqrt((77765166.48357823 / (56)) + (1847582.7417035417 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.08987090619073482 = (228956.5729549334 - 249533.10764471834) / 228956.5729549334 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 21a8eb51ad181f6eb2d7f24d8eda34840025a8a0
Compare 0e6013077eba9e9dc2923c87ff3079cc65d2576e
Diff Diff

Regressions in System.Collections.Tests.Perf_PriorityQueue<String, String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
K_Max_Elements - Duration of single invocation 58.33 μs 65.60 μs 1.12 0.04 False
Dequeue_And_Enqueue - Duration of single invocation 2.39 ms 2.67 ms 1.12 0.14 False
K_Max_Elements - Duration of single invocation 1.11 μs 1.20 μs 1.08 0.08 False

graph
graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.Tests.Perf_PriorityQueue&lt;String, String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.Tests.Perf_PriorityQueue<String, String>.K_Max_Elements(Size: 1000)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 65.60162133891212 > 64.39131418908545.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 12/3/2022 7:24:45 AM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -19.870107768157094 (T) = (0 -65639.16734301811) / Math.Sqrt((4996059.155364104 / (56)) + (1237.0430805201477 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.09965894155060165 = (59690.477531571705 - 65639.16734301811) / 59690.477531571705 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Collections.Tests.Perf_PriorityQueue&lt;String, String&gt;.Dequeue_And_Enqueue(Size: 1000)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 2.6675825 > 2.508173218578297.
IsChangePoint: Marked as a change because one of 12/10/2022 11:25:25 PM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -7.243121613163138 (T) = (0 -2627081.102907509) / Math.Sqrt((8274097196.474718 / (51)) + (3885385876.842158 / (8))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (8) - 2, .025) and -0.07547630488967542 = (2442714.070931577 - 2627081.102907509) / 2442714.070931577 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Collections.Tests.Perf_PriorityQueue&lt;String, String&gt;.K_Max_Elements(Size: 10)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 1.1966253227002022 > 1.165477065763617.
IsChangePoint: Marked as a change because one of 11/11/2022 10:59:41 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -12.576289277282969 (T) = (0 -1201.8755861516945) / Math.Sqrt((805.8062297432698 / (56)) + (72.94207372330789 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.06963083430790551 = (1123.63588221478 - 1201.8755861516945) / 1123.63588221478 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 21a8eb51ad181f6eb2d7f24d8eda34840025a8a0
Compare 0e6013077eba9e9dc2923c87ff3079cc65d2576e
Diff Diff

Regressions in System.Collections.TryGetValueTrue<String, String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SortedList - Duration of single invocation 222.18 μs 250.77 μs 1.13 0.06 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.TryGetValueTrue&lt;String, String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.TryGetValueTrue<String, String>.SortedList(Size: 512)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 250.7730078125 > 233.2419718309859.
IsChangePoint: Marked as a change because one of 11/30/2022 7:06:59 PM, 12/2/2022 2:36:06 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -14.929327887204074 (T) = (0 -251207.96190571584) / Math.Sqrt((108955328.7919482 / (56)) + (439421.94975208765 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.09404453917339915 = (229614.01744714615 - 251207.96190571584) / 229614.01744714615 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added CoreClr untriaged New issue has not been triaged by the area owner labels Dec 13, 2022
@cincuranet cincuranet changed the title [Perf] Windows/x64: 13 Regressions on 12/12/2022 1:34:22 PM Regressions in System.Globalization.Tests.StringEquality Dec 13, 2022
@cincuranet cincuranet removed refs/heads/main untriaged New issue has not been triaged by the area owner labels Dec 13, 2022
@cincuranet cincuranet transferred this issue from dotnet/perf-autofiling-issues Dec 13, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 13, 2022
@cincuranet
Copy link
Contributor

The System.Globalization.Tests.StringEquality is valid regression, others are noise. Commit range likely b5da2c6...853e7e3. My best guess would be #77480.

@cincuranet cincuranet added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Dec 13, 2022
@ghost
Copy link

ghost commented Dec 15, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 21a8eb51ad181f6eb2d7f24d8eda34840025a8a0
Compare 0e6013077eba9e9dc2923c87ff3079cc65d2576e
Diff Diff

Regressions in System.Globalization.Tests.StringEquality

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Compare_DifferentFirstChar - Duration of single invocation 33.47 ns 39.16 ns 1.17 0.09 False
Compare_DifferentFirstChar - Duration of single invocation 32.55 ns 39.50 ns 1.21 0.05 False
Compare_DifferentFirstChar - Duration of single invocation 32.58 ns 39.22 ns 1.20 0.08 False
Compare_Same - Duration of single invocation 889.25 ns 1.46 μs 1.64 0.35 False
Compare_DifferentFirstChar - Duration of single invocation 35.96 ns 39.62 ns 1.10 0.08 False
Compare_DifferentFirstChar - Duration of single invocation 32.67 ns 38.97 ns 1.19 0.05 False

graph
graph
graph
graph
graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Globalization.Tests.StringEquality*'

Payloads

Baseline
Compare

Histogram

System.Globalization.Tests.StringEquality.Compare_DifferentFirstChar(Count: 1024, Options: (, None))

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 39.15915858054264 > 35.108778341417164.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 11/30/2022 12:23:56 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -16.620511958304334 (T) = (0 -39.00635150693171) / Math.Sqrt((4.320881813122062 / (56)) + (0.02181315417479187 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.14130528421530467 = (34.17696566063848 - 39.00635150693171) / 34.17696566063848 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Globalization.Tests.StringEquality.Compare_DifferentFirstChar(Count: 1024, Options: (, IgnoreCase))

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 39.49723524016647 > 34.641022538919614.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 11/30/2022 12:23:56 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -24.807956540349064 (T) = (0 -39.31121806448672) / Math.Sqrt((2.0804968091861418 / (56)) + (0.025963795814297193 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.15615391704311432 = (34.001716799979285 - 39.31121806448672) / 34.001716799979285 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Globalization.Tests.StringEquality.Compare_DifferentFirstChar(Count: 1024, Options: (en-US, IgnoreCase))

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 39.21587344423712 > 34.621688004413365.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 11/30/2022 12:23:56 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -17.565451883521696 (T) = (0 -39.22677078993461) / Math.Sqrt((4.3177269741104665 / (56)) + (0.00024716500128385923 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.14208217925022806 = (34.34671471337274 - 39.22677078993461) / 34.34671471337274 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Globalization.Tests.StringEquality.Compare_Same(Count: 1024, Options: (en-US, IgnoreCase))

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 1.4577780113353265 > 934.6009386052494.
IsChangePoint: Marked as a change because one of 10/19/2022 7:27:15 PM, 10/24/2022 10:11:47 PM, 12/5/2022 7:07:15 PM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -4.019217620487341 (T) = (0 -1131.576000808241) / Math.Sqrt((15412.532326399712 / (21)) + (80576.30181216789 / (38))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (21) + (38) - 2, .025) and -0.2342071550974721 = (916.844466615391 - 1131.576000808241) / 916.844466615391 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Globalization.Tests.StringEquality.Compare_DifferentFirstChar(Count: 1024, Options: (en-US, IgnoreNonSpace))

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 39.619518902658044 > 35.07207436327868.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 11/30/2022 12:23:56 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -20.652209199847032 (T) = (0 -39.36075565704459) / Math.Sqrt((2.4827599520775534 / (56)) + (0.05034755442913553 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.1490471949305536 = (34.25512531660937 - 39.36075565704459) / 34.25512531660937 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Globalization.Tests.StringEquality.Compare_DifferentFirstChar(Count: 1024, Options: (en-US, None))

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 38.96762614998606 > 34.94886401047151.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 11/30/2022 12:23:56 PM, 12/2/2022 5:21:30 AM, 12/2/2022 5:47:06 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -12.293413098086575 (T) = (0 -38.771407867530804) / Math.Sqrt((7.197616037102572 / (56)) + (0.02911100117769796 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.13364164615984075 = (34.20076176529609 - 38.771407867530804) / 34.20076176529609 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS Windows 10.0.19042
Baseline 21a8eb51ad181f6eb2d7f24d8eda34840025a8a0
Compare 0e6013077eba9e9dc2923c87ff3079cc65d2576e
Diff Diff

Regressions in System.Collections.Sort<String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Array_ComparerClass - Duration of single invocation 287.36 μs 315.65 μs 1.10 0.11 False
Array_ComparerStruct - Duration of single invocation 294.22 μs 319.74 μs 1.09 0.21 False

graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.Sort&lt;String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.Sort<String>.Array_ComparerClass(Size: 512)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 315.64525999999995 > 306.2055570000001.
IsChangePoint: Marked as a change because one of 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -3.5350393472228694 (T) = (0 -320130.9474920635) / Math.Sqrt((48488744.37244448 / (56)) + (139739652.10293117 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.08232319894158156 = (295781.2858535453 - 320130.9474920635) / 295781.2858535453 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Collections.Sort&lt;String&gt;.Array_ComparerStruct(Size: 512)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 319.7447613333333 > 309.02046685.
IsChangePoint: Marked as a change because one of 12/9/2022 8:25:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -3.3239285152786495 (T) = (0 -323355.2436194786) / Math.Sqrt((127238018.78475069 / (42)) + (698024517.9561676 / (17))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (42) + (17) - 2, .025) and -0.07325612162760624 = (301284.3226359672 - 323355.2436194786) / 301284.3226359672 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 21a8eb51ad181f6eb2d7f24d8eda34840025a8a0
Compare 0e6013077eba9e9dc2923c87ff3079cc65d2576e
Diff Diff

Regressions in System.Collections.ContainsKeyTrue<String, String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SortedList - Duration of single invocation 219.73 μs 249.86 μs 1.14 0.05 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.ContainsKeyTrue&lt;String, String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.ContainsKeyTrue<String, String>.SortedList(Size: 512)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 249.85857804232808 > 241.1767150421468.
IsChangePoint: Marked as a change because one of 9/29/2022 7:42:19 AM, 10/2/2022 11:57:04 PM, 11/23/2022 1:02:40 AM, 12/3/2022 7:24:45 AM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -14.533377066205812 (T) = (0 -249533.10764471834) / Math.Sqrt((77765166.48357823 / (56)) + (1847582.7417035417 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.08987090619073482 = (228956.5729549334 - 249533.10764471834) / 228956.5729549334 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 21a8eb51ad181f6eb2d7f24d8eda34840025a8a0
Compare 0e6013077eba9e9dc2923c87ff3079cc65d2576e
Diff Diff

Regressions in System.Collections.Tests.Perf_PriorityQueue<String, String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
K_Max_Elements - Duration of single invocation 58.33 μs 65.60 μs 1.12 0.04 False
Dequeue_And_Enqueue - Duration of single invocation 2.39 ms 2.67 ms 1.12 0.14 False
K_Max_Elements - Duration of single invocation 1.11 μs 1.20 μs 1.08 0.08 False

graph
graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.Tests.Perf_PriorityQueue&lt;String, String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.Tests.Perf_PriorityQueue<String, String>.K_Max_Elements(Size: 1000)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 65.60162133891212 > 64.39131418908545.
IsChangePoint: Marked as a change because one of 11/23/2022 1:02:40 AM, 12/3/2022 7:24:45 AM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -19.870107768157094 (T) = (0 -65639.16734301811) / Math.Sqrt((4996059.155364104 / (56)) + (1237.0430805201477 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.09965894155060165 = (59690.477531571705 - 65639.16734301811) / 59690.477531571705 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Collections.Tests.Perf_PriorityQueue&lt;String, String&gt;.Dequeue_And_Enqueue(Size: 1000)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 2.6675825 > 2.508173218578297.
IsChangePoint: Marked as a change because one of 12/10/2022 11:25:25 PM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -7.243121613163138 (T) = (0 -2627081.102907509) / Math.Sqrt((8274097196.474718 / (51)) + (3885385876.842158 / (8))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (8) - 2, .025) and -0.07547630488967542 = (2442714.070931577 - 2627081.102907509) / 2442714.070931577 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Collections.Tests.Perf_PriorityQueue&lt;String, String&gt;.K_Max_Elements(Size: 10)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 1.1966253227002022 > 1.165477065763617.
IsChangePoint: Marked as a change because one of 11/11/2022 10:59:41 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -12.576289277282969 (T) = (0 -1201.8755861516945) / Math.Sqrt((805.8062297432698 / (56)) + (72.94207372330789 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.06963083430790551 = (1123.63588221478 - 1201.8755861516945) / 1123.63588221478 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 21a8eb51ad181f6eb2d7f24d8eda34840025a8a0
Compare 0e6013077eba9e9dc2923c87ff3079cc65d2576e
Diff Diff

Regressions in System.Collections.TryGetValueTrue<String, String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SortedList - Duration of single invocation 222.18 μs 250.77 μs 1.13 0.06 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.TryGetValueTrue&lt;String, String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.TryGetValueTrue<String, String>.SortedList(Size: 512)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 250.7730078125 > 233.2419718309859.
IsChangePoint: Marked as a change because one of 11/30/2022 7:06:59 PM, 12/2/2022 2:36:06 PM, 12/12/2022 10:47:19 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -14.929327887204074 (T) = (0 -251207.96190571584) / Math.Sqrt((108955328.7919482 / (56)) + (439421.94975208765 / (3))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (3) - 2, .025) and -0.09404453917339915 = (229614.01744714615 - 251207.96190571584) / 229614.01744714615 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: dakersnar
Labels:

tenet-performance, tenet-performance-benchmarks, area-GC-coreclr, untriaged
Milestone: -

@mangod9
Copy link
Member

mangod9 commented Dec 15, 2022

looking at @PeterSolMS change tagged above, would be surprised if its related. @cincuranet, could you please clarify how much has the stringEquality test has regressed?

@cincuranet
Copy link
Contributor

cincuranet commented Dec 15, 2022 •
edited
Loading

For example the System.Globalization.Tests.StringEquality.Compare_DifferentFirstChar(Count: 1024, Options: (, IgnoreCase)) went from roughly 33-34 ns to 39 ns.

Could be also noise. Wanna wait for more numbers?

@mangod9
Copy link
Member

mangod9 commented Dec 15, 2022

yeah might be worth waiting a few more builds, unless @PeterSolMS feels it could be possibly related. Thx.

@PeterSolMS
Copy link
Contributor

I ran the System.Globalization.Tests.StringEquality tests under the profiler, and as they spend little time in either the GC itself or the allocator, I feel the regression is unlikely to be related to #77480.

@cincuranet
Copy link
Contributor

With more data it's clearly noise. Closing.

@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jan 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dakersnar dakersnar

Labels
area-GC-coreclr tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cincuranet @jeffschwMSFT @PeterSolMS @dakersnar @mangod9